Merge lp:~ruben-verweij/unity/fix-677594-workspaces into lp:unity
Proposed by
Ruben Verweij
Status: | Merged |
---|---|
Merged at revision: | 860 |
Proposed branch: | lp:~ruben-verweij/unity/fix-677594-workspaces |
Merge into: | lp:unity |
Diff against target: |
137 lines (+63/-13) 4 files modified
src/LauncherController.cpp (+36/-13) src/LauncherController.h (+4/-0) src/unityshell.cpp (+18/-0) src/unityshell.h (+5/-0) |
To merge this branch: | bzr merge lp:~ruben-verweij/unity/fix-677594-workspaces |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Barth (community) | Approve | ||
Jason Smith (community) | Approve | ||
Ruben Verweij (community) | Needs Resubmitting | ||
Alex Launi (community) | Needs Fixing | ||
Neil J. Patel | Pending | ||
Review via email: mp+43280@code.launchpad.net |
This proposal supersedes a proposal from 2010-12-08.
Description of the change
Thanks for your quick reply and feedback!
I have updated the code as you have suggested, but I can't test it.
I am running Natty, how do I compile "my version" of Unity and run it to test whether it works?
Thanks again for your help!
To post a comment you must log in.
Hi,
You don't need to use gconf to do this, you can just ask compiz directly for the number of workspaces with screen->vpSize ().width ();
Also if you want to be notified when this number changes you can implement a
bool :setOptionForPl ugin (const char *plugin, const char *name, CompOption::Value &v) and make sure that UnityScreen inherits ScreenInterface (and that we call ScreenInterface ::setHandler (screen) in the UnityScreen construtor) and then check for plugin == "core" and name == "hsize" and react on that change.
UnityScreen:
See git.compiz. org/compiz/ core/plugins/ cube/src/ cube.cpp: 1622 for some ideas on this.
Remind me that this method is full of suck and I need to change it.