Merge lp:~rsalveti/firefox/disable-thumb2 into lp:firefox/trunk

Proposed by Ricardo Salveti
Status: Rejected
Rejected by: Rico Tzschichholz
Proposed branch: lp:~rsalveti/firefox/disable-thumb2
Merge into: lp:firefox/trunk
Diff against target: 39 lines (+8/-0)
2 files modified
debian/changelog (+4/-0)
debian/rules (+4/-0)
To merge this branch: bzr merge lp:~rsalveti/firefox/disable-thumb2
Reviewer Review Type Date Requested Status
Chris Coulson Pending
Review via email: mp+65758@code.launchpad.net

Description of the change

As described by bug 789198, THUMB2 breaks WebM functionality on ARM, and as side effect people can't use youtube even with html5 support.

This patch changes it in a way to make it easier to build with thumb2 again, so people can easily try the thumb2 enabled build to debug the issue.

To post a comment you must log in.

Unmerged revisions

892. By Ricardo Salveti

Disable THUMB2 support at ARM by default to have proper WebM support an
let users play html5 videos (LP: #789198)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-06-23 16:42:47 +0000
+++ debian/changelog 2011-06-24 02:22:23 +0000
@@ -52,6 +52,10 @@
52 - update debian/control.langpacks52 - update debian/control.langpacks
53 - refresh debian/control53 - refresh debian/control
5454
55 [ Ricardo Salveti de Araujo <ricardo.salveti@linaro.org ]
56 * Disable THUMB2 support at ARM by default to have proper WebM support an
57 let users play html5 videos (LP: #789198)
58
55 -- Chris Coulson <chris.coulson@canonical.com> Wed, 22 Jun 2011 23:53:29 +010059 -- Chris Coulson <chris.coulson@canonical.com> Wed, 22 Jun 2011 23:53:29 +0100
5660
57firefox-trunk (6.0~a1~hg20110523r69965+nobinonly-0ubuntu1) oneiric; urgency=low61firefox-trunk (6.0~a1~hg20110523r69965+nobinonly-0ubuntu1) oneiric; urgency=low
5862
=== modified file 'debian/rules'
--- debian/rules 2011-06-18 20:05:02 +0000
+++ debian/rules 2011-06-24 02:22:23 +0000
@@ -21,6 +21,8 @@
21MOZ_DEBUG ?= 021MOZ_DEBUG ?= 0
22# 1 = Disable optimizations22# 1 = Disable optimizations
23MOZ_NO_OPTIMIZE ?= 023MOZ_NO_OPTIMIZE ?= 0
24# 1 = Enable THUMB2 support when building for ARM
25MOZ_THUMB2 ?= 0
2426
25# These are used for cross-compiling and for saving the configure script27# These are used for cross-compiling and for saving the configure script
26# from having to guess our platform (since we know it already)28# from having to guess our platform (since we know it already)
@@ -248,9 +250,11 @@
248ifeq (1,$(MOZ_DEBUG))250ifeq (1,$(MOZ_DEBUG))
249 DEB_DEFINES += -DMOZ_DEBUG251 DEB_DEFINES += -DMOZ_DEBUG
250endif252endif
253ifeq (1,$(MOZ_THUMB2))
251ifneq (,$(findstring armel,$(DEB_HOST_ARCH)))254ifneq (,$(findstring armel,$(DEB_HOST_ARCH)))
252 DEB_DEFINES += -DDEB_ENABLE_THUMB2255 DEB_DEFINES += -DDEB_ENABLE_THUMB2
253endif256endif
257endif
254ifeq (1,$(MOZ_ENABLE_GLOBALMENU))258ifeq (1,$(MOZ_ENABLE_GLOBALMENU))
255 DEB_DEFINES += -DMOZ_ENABLE_GLOBALMENU259 DEB_DEFINES += -DMOZ_ENABLE_GLOBALMENU
256endif260endif

Subscribers

People subscribed via source and target branches