Merge ~rodrigo-zaiden/ubuntu-security-tools:fix-build-source-list into ubuntu-security-tools:master
Status: | Needs review |
---|---|
Proposed branch: | ~rodrigo-zaiden/ubuntu-security-tools:fix-build-source-list |
Merge into: | ubuntu-security-tools:master |
Diff against target: |
45 lines (+17/-15) 1 file modified
build-tools/build-sources-list (+17/-15) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Eduardo Barretto | Needs Fixing | ||
Review via email: mp+420586@code.launchpad.net |
Commit message
UST: build-source-list: change build ESM PPAs
From the ubuntu-
to add an ESM release, if an user has a release in the format
'release/esm-x' it was not building correctly.
If the format 'esm-x/release' is used, it is not being handled.
The exception case is for Precise and Trusty that should be created
in the format 'release/esm'
Description of the change
I've seen some different ways to describe an ESM release in
~/.ubuntu-
`esm-apps/focal` or `focal/esm-apps`
I'm using the first and I noticed that it was not building the PPAs
correctly, since this case was not handled.
I couldn't find a "correct" format, and as far as I checked, both seems
to be accepted.
In this commit, I'm trying to accept both and handle both.
I understand that in the ideal world, I could be generating the auth part
in the correct file, but for now the warning note remains, I'm just trying
to make this script usable in case someone tries it.
The only special case is for trusty and precise that should be handled
as release/esm since they only have one component. Actually, it could be
time to remove Precise, but I decided to first push with it as it was
still there and if someone thinks that we should remove it, I can create
a new commit.
Thank you!
we should not support the format 'release/ esm-{infra/ apps}', please follow the new CVE file format which is:
PRODUCT/RELEASE
so it should be:
esm/precise [1]
esm/trusty [1]
esm-infra/xenial
esm-apps/xenial
esm-apps/bionic
esm-apps/focal
esm-apps/jammy
[1] Please note that precise and trusty we do have alias setup to accept trusty/esm and precise/esm and this was a decision so we don't have to touch all our CVEs and infrastructure as their ESM came before the new CVE file format.