Merge lp:~rockstar/launchpad/fix-buildds into lp:launchpad

Proposed by Paul Hummer
Status: Merged
Approved by: Tim Penhey
Approved revision: no longer in the source branch.
Merged at revision: 10971
Proposed branch: lp:~rockstar/launchpad/fix-buildds
Merge into: lp:launchpad
Diff against target: 60 lines (+3/-9)
2 files modified
lib/canonical/buildd/buildrecipe (+1/-3)
lib/canonical/buildd/sourcepackagerecipe.py (+2/-6)
To merge this branch: bzr merge lp:~rockstar/launchpad/fix-buildds
Reviewer Review Type Date Requested Status
Tim Penhey (community) Approve
William Grant Approve
Review via email: mp+26990@code.launchpad.net

Description of the change

Fix the buildds from shitting themselves.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) wrote :

Looks good. It's the same diff I had.

review: Approve
Revision history for this message
Tim Penhey (thumper) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/canonical/buildd/buildrecipe'
--- lib/canonical/buildd/buildrecipe 2010-04-20 01:36:29 +0000
+++ lib/canonical/buildd/buildrecipe 2010-06-07 22:40:48 +0000
@@ -24,20 +24,18 @@
24 """Builds a package from a recipe."""24 """Builds a package from a recipe."""
2525
26 def __init__(self, build_id, author_name, author_email,26 def __init__(self, build_id, author_name, author_email,
27 package_name, suite, distroseries_name):27 suite, distroseries_name):
28 """Constructor.28 """Constructor.
2929
30 :param build_id: The id of the build (a str).30 :param build_id: The id of the build (a str).
31 :param author_name: The name of the author (a str).31 :param author_name: The name of the author (a str).
32 :param author_email: The email address of the author (a str).32 :param author_email: The email address of the author (a str).
33 :param package_name: The name of the package (a str).
34 :param suite: The suite the package should be built for (a str).33 :param suite: The suite the package should be built for (a str).
35 """34 """
36 self.build_id = build_id35 self.build_id = build_id
37 self.author_name = author_name36 self.author_name = author_name
38 self.author_email = author_email37 self.author_email = author_email
39 self.distroseries_name = distroseries_name38 self.distroseries_name = distroseries_name
40 self.package_name = package_name
41 self.suite = suite39 self.suite = suite
42 self.base_branch = None40 self.base_branch = None
43 self.chroot_path = get_build_path(build_id, 'chroot-autobuild')41 self.chroot_path = get_build_path(build_id, 'chroot-autobuild')
4442
=== modified file 'lib/canonical/buildd/sourcepackagerecipe.py'
--- lib/canonical/buildd/sourcepackagerecipe.py 2010-04-20 01:36:29 +0000
+++ lib/canonical/buildd/sourcepackagerecipe.py 2010-06-07 22:40:48 +0000
@@ -72,7 +72,6 @@
72 self.recipe_text = extra_args['recipe_text']72 self.recipe_text = extra_args['recipe_text']
73 self.suite = extra_args['suite']73 self.suite = extra_args['suite']
74 self.component = extra_args['ogrecomponent']74 self.component = extra_args['ogrecomponent']
75 self.package_name = extra_args['package_name']
76 self.author_name = extra_args['author_name']75 self.author_name = extra_args['author_name']
77 self.author_email = extra_args['author_email']76 self.author_email = extra_args['author_email']
78 self.archive_purpose = extra_args['archive_purpose']77 self.archive_purpose = extra_args['archive_purpose']
@@ -86,20 +85,17 @@
86 currently_building = get_build_path(85 currently_building = get_build_path(
87 self._buildid, 'chroot-autobuild/CurrentlyBuilding')86 self._buildid, 'chroot-autobuild/CurrentlyBuilding')
88 splat_file(currently_building,87 splat_file(currently_building,
89 'Package: %s\n'
90 'Suite: %s\n'88 'Suite: %s\n'
91 'Component: %s\n'89 'Component: %s\n'
92 'Purpose: %s\n'90 'Purpose: %s\n'
93 'Build-Debug-Symbols: no\n' %91 'Build-Debug-Symbols: no\n' %
94 (self.package_name, self.suite, self.component,92 (self.suite, self.component, self.archive_purpose))
95 self.archive_purpose))
96 os.makedirs(get_chroot_path(self._buildid, 'work'))93 os.makedirs(get_chroot_path(self._buildid, 'work'))
97 recipe_path = get_chroot_path(self._buildid, 'work/recipe')94 recipe_path = get_chroot_path(self._buildid, 'work/recipe')
98 splat_file(recipe_path, self.recipe_text)95 splat_file(recipe_path, self.recipe_text)
99 args = [96 args = [
100 "buildrecipe.py", self._buildid, self.author_name,97 "buildrecipe.py", self._buildid, self.author_name,
101 self.author_email, self.package_name, self.suite,98 self.author_email, self.suite, self.distroseries_name]
102 self.distroseries_name]
103 self.runSubProcess(self.build_recipe_path, args)99 self.runSubProcess(self.build_recipe_path, args)
104100
105 def iterate_BUILD_RECIPE(self, retcode):101 def iterate_BUILD_RECIPE(self, retcode):