Merge lp:~robert-ancell/unity-control-center/legacy-width-code into lp:unity-control-center

Proposed by Robert Ancell
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 12852
Merged at revision: 12855
Proposed branch: lp:~robert-ancell/unity-control-center/legacy-width-code
Merge into: lp:unity-control-center
Diff against target: 69 lines (+10/-28)
1 file modified
shell/gnome-control-center.c (+10/-28)
To merge this branch: bzr merge lp:~robert-ancell/unity-control-center/legacy-width-code
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+288580@code.launchpad.net

Commit message

Drop legacy g-c-c code for panel width.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

right!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'shell/gnome-control-center.c'
--- shell/gnome-control-center.c 2014-02-24 17:28:38 +0000
+++ shell/gnome-control-center.c 2016-03-09 22:24:54 +0000
@@ -50,8 +50,7 @@
50/* Use a fixed width for the shell, since resizing horizontally is more awkward50/* Use a fixed width for the shell, since resizing horizontally is more awkward
51 * for the user than resizing vertically51 * for the user than resizing vertically
52 * Both sizes are defined in https://live.gnome.org/Design/SystemSettings/ */52 * Both sizes are defined in https://live.gnome.org/Design/SystemSettings/ */
53#define FIXED_WIDTH 74053#define FIXED_WIDTH 850
54#define UNITY_FIXED_WIDTH 850
55#define FIXED_HEIGHT 65054#define FIXED_HEIGHT 650
56#define SMALL_SCREEN_FIXED_HEIGHT 40055#define SMALL_SCREEN_FIXED_HEIGHT 400
5756
@@ -1116,12 +1115,8 @@
1116 gtk_widget_show (W (priv->builder, "search-entry"));1115 gtk_widget_show (W (priv->builder, "search-entry"));
1117 gtk_widget_hide (W (priv->builder, "lock-button"));1116 gtk_widget_hide (W (priv->builder, "lock-button"));
11181117
1119 if (!g_strcmp0(g_getenv("XDG_CURRENT_DESKTOP"), "Unity"))1118 gtk_widget_get_preferred_height_for_width (GTK_WIDGET (priv->main_vbox),
1120 gtk_widget_get_preferred_height_for_width (GTK_WIDGET (priv->main_vbox),1119 FIXED_WIDTH, NULL, &nat_height);
1121 UNITY_FIXED_WIDTH, NULL, &nat_height);
1122 else
1123 gtk_widget_get_preferred_height_for_width (GTK_WIDGET (priv->main_vbox),
1124 FIXED_WIDTH, NULL, &nat_height);
1125 gtk_scrolled_window_set_min_content_height (GTK_SCROLLED_WINDOW (priv->scrolled_window),1120 gtk_scrolled_window_set_min_content_height (GTK_SCROLLED_WINDOW (priv->scrolled_window),
1126 priv->small_screen == SMALL_SCREEN_TRUE ? SMALL_SCREEN_FIXED_HEIGHT : nat_height);1121 priv->small_screen == SMALL_SCREEN_TRUE ? SMALL_SCREEN_FIXED_HEIGHT : nat_height);
1127 }1122 }
@@ -1130,22 +1125,12 @@
1130 gtk_widget_hide (W (priv->builder, "search-entry"));1125 gtk_widget_hide (W (priv->builder, "search-entry"));
1131 /* set the scrolled window small so that it doesn't force1126 /* set the scrolled window small so that it doesn't force
1132 the window to be larger than this panel */1127 the window to be larger than this panel */
1133 if (!g_strcmp0(g_getenv("XDG_CURRENT_DESKTOP"), "Unity")) {1128 gtk_widget_get_preferred_height_for_width (GTK_WIDGET (priv->window),
1134 gtk_widget_get_preferred_height_for_width (GTK_WIDGET (priv->window),1129 FIXED_WIDTH, NULL, &nat_height);
1135 UNITY_FIXED_WIDTH, NULL, &nat_height);1130 gtk_scrolled_window_set_min_content_height (GTK_SCROLLED_WINDOW (priv->scrolled_window), MIN_ICON_VIEW_HEIGHT);
1136 gtk_scrolled_window_set_min_content_height (GTK_SCROLLED_WINDOW (priv->scrolled_window), MIN_ICON_VIEW_HEIGHT);1131 gtk_window_resize (GTK_WINDOW (priv->window),
1137 gtk_window_resize (GTK_WINDOW (priv->window),1132 FIXED_WIDTH,
1138 UNITY_FIXED_WIDTH,1133 nat_height);
1139 nat_height);
1140 }
1141 else {
1142 gtk_widget_get_preferred_height_for_width (GTK_WIDGET (priv->window),
1143 FIXED_WIDTH, NULL, &nat_height);
1144 gtk_scrolled_window_set_min_content_height (GTK_SCROLLED_WINDOW (priv->scrolled_window), MIN_ICON_VIEW_HEIGHT);
1145 gtk_window_resize (GTK_WINDOW (priv->window),
1146 FIXED_WIDTH,
1147 nat_height);
1148 }
1149 }1134 }
1150}1135}
11511136
@@ -1605,10 +1590,7 @@
1605 /* Main scrolled window */1590 /* Main scrolled window */
1606 priv->scrolled_window = W (priv->builder, "scrolledwindow1");1591 priv->scrolled_window = W (priv->builder, "scrolledwindow1");
16071592
1608 if (!g_strcmp0(g_getenv("XDG_CURRENT_DESKTOP"), "Unity"))1593 gtk_widget_set_size_request (priv->scrolled_window, FIXED_WIDTH, -1);
1609 gtk_widget_set_size_request (priv->scrolled_window, UNITY_FIXED_WIDTH, -1);
1610 else
1611 gtk_widget_set_size_request (priv->scrolled_window, FIXED_WIDTH, -1);
1612 priv->main_vbox = W (priv->builder, "main-vbox");1594 priv->main_vbox = W (priv->builder, "main-vbox");
1613 g_signal_connect (priv->notebook, "notify::page",1595 g_signal_connect (priv->notebook, "notify::page",
1614 G_CALLBACK (notebook_page_notify_cb), priv);1596 G_CALLBACK (notebook_page_notify_cb), priv);

Subscribers

People subscribed via source and target branches