Merge lp:~roadmr/checkbox/phoronix-verbose-output into lp:checkbox

Proposed by Daniel Manrique
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 1907
Merged at revision: 1908
Proposed branch: lp:~roadmr/checkbox/phoronix-verbose-output
Merge into: lp:checkbox
Diff against target: 39 lines (+18/-2)
2 files modified
debian/changelog (+2/-0)
scripts/pts_run (+16/-2)
To merge this branch: bzr merge lp:~roadmr/checkbox/phoronix-verbose-output
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+145966@code.launchpad.net

Description of the change

changes to log the full phoronix console output as the comment, this will ease debugging and will be clearer than the current output, which is just a number representing FPS. Without context this number is a bit hard to interpret.

This doesn't entirely fix the linked bug, but that bug showed that without proper information it's very painful and slow to debug problems like the one reported.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks good, crappy phoronix

review: Approve
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

NOTE: it would be really awesome if we could get integration tests for that, would you want to work on one with me? It's really easy to do I hope (if not, I want to know)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-01-31 00:29:39 +0000
+++ debian/changelog 2013-01-31 20:10:35 +0000
@@ -4,6 +4,8 @@
4 * Bumped revision number to 0.15.1 and restored previous trunk changelog.4 * Bumped revision number to 0.15.1 and restored previous trunk changelog.
5 * jobs/peripheral.txt.in: fixed string with repeated "add" (LP: #1102665) 5 * jobs/peripheral.txt.in: fixed string with repeated "add" (LP: #1102665)
6 * scripts/graphics_stress_test: added missing import (LP: #1102812)6 * scripts/graphics_stress_test: added missing import (LP: #1102812)
7 * scripts/pts_run: modified to output the full log from phoronix-test-suite
8 (LP: #1102819)
79
8 [ Jeff Lane ]10 [ Jeff Lane ]
9 * scripts/rendercheck_test - added missing import for errno (LP: #1103343)11 * scripts/rendercheck_test - added missing import for errno (LP: #1103343)
1012
=== modified file 'scripts/pts_run'
--- scripts/pts_run 2012-10-09 10:00:34 +0000
+++ scripts/pts_run 2013-01-31 20:10:35 +0000
@@ -15,6 +15,20 @@
15# Run only the following resolution15# Run only the following resolution
16export OVERRIDE_VIDEO_MODES=800x60016export OVERRIDE_VIDEO_MODES=800x600
1717
18set +o errexit
19rv=0
18output=$(phoronix-test-suite batch-benchmark $@ 2>&1)20output=$(phoronix-test-suite batch-benchmark $@ 2>&1)
19echo $output | grep -q -i 'This test failed to run properly'21#The output does NOT report success. It may contain, if it fails:
20echo $output | sed 's/.*Average: //'22# The test did not produce a result
23# The test failed to run properly
24# Failed to Fetch
25
26if (echo "$output" | grep -q -i "Failed to fetch" ); then
27 rv=1
28fi
29if ( echo "$output" | grep -q -i 'This test failed to run properly'); then
30 rv=1
31fi
32echo "$output"
33exit $rv
34

Subscribers

People subscribed via source and target branches