Merge lp:~roadmr/canonical-identity-provider/gdpr-report into lp:canonical-identity-provider/release
Status: | Merged |
---|---|
Approved by: | Daniel Manrique |
Approved revision: | no longer in the source branch. |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | lp:~roadmr/canonical-identity-provider/gdpr-report |
Merge into: | lp:canonical-identity-provider/release |
Diff against target: |
164 lines (+119/-1) 3 files modified
src/identityprovider/admin.py (+12/-1) src/identityprovider/templates/admin/gdpr_report.html (+47/-0) src/identityprovider/tests/test_admin.py (+60/-0) |
To merge this branch: | bzr merge lp:~roadmr/canonical-identity-provider/gdpr-report |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Maximiliano Bertacchini | Approve | ||
Review via email: mp+365134@code.launchpad.net |
Commit message
Add GDPR report admin action for accounts.
The intent is to have a read-only, copy-pasteable view for GDPR requests.
Currently the information to be reported is scattered between the Account
change form and the auth logs changelist. The Account form contains most of the
relevant data but since it's a form, it can't be cleanly copy-pasted.
If more GDPR-relevant information is required, this view can easily be expanded
to present that as well.
Description of the change
Add GDPR report admin action for accounts.
The intent is to have a read-only, copy-pasteable view for GDPR requests.
Currently the information to be reported is scattered between the Account
change form and the auth logs changelist. The Account form contains most of the
relevant data but since it's a form, it can't be cleanly copy-pasted.
If more GDPR-relevant information is required, this view can easily be expanded
to present that as well.
LGTM, but check a couple of questions inline. Thanks!