Merge lp:~ricotz/slingshot/plank-0.11 into lp:~elementary-pantheon/slingshot/trunk

Proposed by Rico Tzschichholz
Status: Merged
Merged at revision: 595
Proposed branch: lp:~ricotz/slingshot/plank-0.11
Merge into: lp:~elementary-pantheon/slingshot/trunk
Diff against target: 46 lines (+17/-3)
2 files modified
CMakeLists.txt (+9/-3)
src/Widgets/AppEntry.vala (+8/-0)
To merge this branch: bzr merge lp:~ricotz/slingshot/plank-0.11
Reviewer Review Type Date Requested Status
xapantu (community) Needs Information
Review via email: mp+276553@code.launchpad.net

Description of the change

This should be merged/pushed after plank 0.10.9 hit the daily PPA

To post a comment you must log in.
Revision history for this message
xapantu (xapantu) wrote :

Why? What is the conditional build system for then?

review: Needs Information
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

> Why? What is the conditional build system for then?

Just to avoid tampering with the recipe to force a rebuild. So this merge actually triggers the needed rebuild.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2015-08-20 05:36:12 +0000
+++ CMakeLists.txt 2015-11-03 15:37:46 +0000
@@ -56,10 +56,16 @@
5656
57find_package (PkgConfig)57find_package (PkgConfig)
58 58
59pkg_check_modules(PLANK QUIET plank>=0.8.1.1197)59pkg_check_modules(PLANK011 QUIET plank>=0.10.9)
60if (PLANK_FOUND)60if (PLANK011_FOUND)
61 set (PLANK_DEPS plank)61 set (PLANK_DEPS plank)
62 set (PLANK_OPTIONS --define=HAS_PLANK)62 set (PLANK_OPTIONS --define=HAS_PLANK --define=HAS_PLANK_0_11)
63else ()
64 pkg_check_modules(PLANK QUIET plank>=0.9.0)
65 if (PLANK_FOUND)
66 set (PLANK_DEPS plank)
67 set (PLANK_OPTIONS --define=HAS_PLANK)
68 endif ()
63endif ()69endif ()
6470
65set (CORE_DEPS "gobject-2.0;glib-2.0;gio-2.0;gio-unix-2.0;libsoup-2.4;gee-0.8;libgnome-menu-3.0;json-glib-1.0;${UNITY_DEPS};${PLANK_DEPS};")71set (CORE_DEPS "gobject-2.0;glib-2.0;gio-2.0;gio-unix-2.0;libsoup-2.4;gee-0.8;libgnome-menu-3.0;json-glib-1.0;${UNITY_DEPS};${PLANK_DEPS};")
6672
=== modified file 'src/Widgets/AppEntry.vala'
--- src/Widgets/AppEntry.vala 2015-03-26 21:42:32 +0000
+++ src/Widgets/AppEntry.vala 2015-11-03 15:37:46 +0000
@@ -37,10 +37,18 @@
3737
38#if HAS_PLANK38#if HAS_PLANK
39 static construct {39 static construct {
40#if HAS_PLANK_0_11
41 plank_client = Plank.DBusClient.get_instance ();
42#else
40 plank_client = Plank.DBus.Client.get_instance ();43 plank_client = Plank.DBus.Client.get_instance ();
44#endif
41 }45 }
4246
47#if HAS_PLANK_0_11
48 private static Plank.DBusClient plank_client;
49#else
43 private static Plank.DBus.Client plank_client;50 private static Plank.DBus.Client plank_client;
51#endif
44 private bool docked = false;52 private bool docked = false;
45 private string desktop_uri;53 private string desktop_uri;
46#endif54#endif

Subscribers

People subscribed via source and target branches