Merge lp:~renatofilho/ubuntu-filemanager-app/snappy into lp:ubuntu-filemanager-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 🦄
Approved revision: 578
Merged at revision: 575
Proposed branch: lp:~renatofilho/ubuntu-filemanager-app/snappy
Merge into: lp:ubuntu-filemanager-app
Diff against target: 126 lines (+108/-0)
3 files modified
setup/gui/ubuntu-filemanager-app.desktop (+47/-0)
snapcraft.yaml (+55/-0)
ubuntu-filemanager-app.wrapper (+6/-0)
To merge this branch: bzr merge lp:~renatofilho/ubuntu-filemanager-app/snappy
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 🦄 (community) Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+308050@code.launchpad.net

Commit message

created snappy package.

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

Running snapcraft on this branch in xenial results in:-

Error downloading stage packages for part 'ubuntu-filemanager-app': no such package 'qtdeclarative5-nemo-qml-plugin-folderlistmodel'

Is this only intended to work on yakkety?

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Humm just noticed that I have this package installed from dpm repository:

apt-cache policy qtdeclarative5-nemo-qml-plugin-folderlistmodel

qtdeclarative5-nemo-qml-plugin-folderlistmodel:
  Installed: (none)
  Candidate: 0.4ubuntu1+bzr574~ubuntu16.04.1
  Version table:
     0.4ubuntu1+bzr574~ubuntu16.04.1 500
        500 http://ppa.launchpad.net/dpm/ppa/ubuntu xenial/main amd64 Packages

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

let me try to fix that. this should not be necessary.

578. By Renato Araujo Oliveira Filho

Removed built in packages from dep list.

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

> Running snapcraft on this branch in xenial results in:-
>
> Error downloading stage packages for part 'ubuntu-filemanager-app': no such
> package 'qtdeclarative5-nemo-qml-plugin-folderlistmodel'
>
> Is this only intended to work on yakkety?

Thanks for point that. These packages are builtin packages, they should not be listed on the dep list.

Fixed on Rv.578

Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added directory 'setup'
=== added directory 'setup/gui'
=== added file 'setup/gui/icon.png'
0Binary files setup/gui/icon.png 1970-01-01 00:00:00 +0000 and setup/gui/icon.png 2016-10-10 14:45:34 +0000 differ0Binary files setup/gui/icon.png 1970-01-01 00:00:00 +0000 and setup/gui/icon.png 2016-10-10 14:45:34 +0000 differ
=== added file 'setup/gui/ubuntu-filemanager-app.desktop'
--- setup/gui/ubuntu-filemanager-app.desktop 1970-01-01 00:00:00 +0000
+++ setup/gui/ubuntu-filemanager-app.desktop 2016-10-10 14:45:34 +0000
@@ -0,0 +1,47 @@
1[Desktop Entry]
2Version=1.0
3Type=Application
4Terminal=false
5Exec=ubuntu-filemanager-app %u
6Icon=/snap/ubuntu-filemanager-app/current/usr/share/filemanager/filemanager64.png
7Name=File Manager
8Name[am]=የ ፋይል አስተዳዳሪ
9Name[ast]=Xestor de ficheros
10Name[be]=Кіраўнік файлаў
11Name[br]=Merer restroù
12Name[bs]=Menadžer datoteka
13Name[ca]=Gestor de fitxers
14Name[cs]=Správce souborů
15Name[de]=Dateiverwaltung
16Name[el]=Διαχειριστής αρχείων
17Name[en_GB]=File Manager
18Name[eo]=Dosieradministrilo
19Name[es]=Gestor de archivos
20Name[eu]=Fitxategi-kudeatzailea
21Name[fa]=مدیر پرونده
22Name[fi]=Tiedostoselain
23Name[fr]=Gestionnaire de fichiers
24Name[fr_CA]=Gestionnaire de fichiers
25Name[gd]=Manaidsear fhaidhlichean
26Name[gl]=Xestor de ficheiros
27Name[hu]=Fájlkezelő
28Name[id]=Manajer Berkas
29Name[it]=Gestore file
30Name[lv]=Datņu pārvaldnieks
31Name[nb]=Filbehandling
32Name[pa]=ਫ਼ਾਈਲ ਮੈਨੇਜਰ
33Name[pl]=Menedżer plików
34Name[pt]=Gestor de ficheiros
35Name[pt_BR]=Gerenciador de arquivos
36Name[shn]=တူဝ်ၸတ်းၵၢၼ် ၾၢႆႇ
37Name[sk]=Správca súborov
38Name[sl]=Upravljalnik datotek
39Name[sr]=Управник датотека
40Name[tr]=Dosya Yöneticisi
41Name[ug]=ھۆججەت باشقۇرغۇ
42Name[zh_CN]=文件管理器
43Name[zh_TW]=檔案管理員
44X-Ubuntu-Touch=true
45X-Ubuntu-Default-Department-ID=accessories
46X-Ubuntu-Splash-Show-Header=true
47X-Ubuntu-Splash-Color=#F5F5F5
048
=== added file 'snapcraft.yaml'
--- snapcraft.yaml 1970-01-01 00:00:00 +0000
+++ snapcraft.yaml 2016-10-10 14:45:34 +0000
@@ -0,0 +1,55 @@
1name: ubuntu-filemanager-app
2version: 0.4
3summary: File Manager application
4description: Core File Manager application
5confinement: devmode # use "strict" to enforce system access only via declared interfaces
6grade: devel
7
8apps:
9 ubuntu-filemanager-app:
10 command: desktop-launch $SNAP/bin/ubuntu-filemanager-app --desktop_file_hint=unity8 "$@"
11 plugs: [unity7, opengl, home]
12
13parts:
14 ubuntu-filemanager-app:
15 plugin: cmake
16 configflags: [-DCMAKE_INSTALL_PREFIX=/usr, -DCLICK_MODE=off]
17 source: .
18 build-packages:
19 - cmake
20 - gcc
21 - g++
22 - intltool
23 - qtbase5-dev
24 - qtdeclarative5-dev
25 - qt5-default
26 - pkg-kde-tools
27 - python3-all
28 - libtag1-dev
29 - libpam0g-dev
30 - libsmbclient-dev
31
32 stage-packages:
33 - qtdeclarative5-qtquick2-plugin
34 - qtdeclarative5-u1db1.0
35 - qml-module-ubuntu-components
36 - qtdeclarative5-ubuntu-content1
37 - libsmbclient
38 - qtubuntu-desktop
39 - suru-icon-theme
40 - mir-graphics-drivers-desktop
41 - humanity-icon-theme
42
43 snap:
44 - -usr/lib/python3
45 - -usr/share/doc
46 - -usr/include
47
48 after: [desktop-qt5]
49
50 environment:
51 source: .
52 plugin: dump
53 organize:
54 ubuntu-filemanager-app.wrapper: bin/ubuntu-filemanager-app
55
056
=== added file 'ubuntu-filemanager-app.wrapper'
--- ubuntu-filemanager-app.wrapper 1970-01-01 00:00:00 +0000
+++ ubuntu-filemanager-app.wrapper 2016-10-10 14:45:34 +0000
@@ -0,0 +1,6 @@
1#!/bin/bash
2
3#Overwrite snappy home dir and use the real home dir
4export HOME="/home/$USER"
5
6exec "$SNAP/usr/bin/filemanager" "$@"

Subscribers

People subscribed via source and target branches