Merge lp:~renatofilho/mediaplayer-app/no-uap-files into lp:mediaplayer-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Merged at revision: 448
Proposed branch: lp:~renatofilho/mediaplayer-app/no-uap-files
Merge into: lp:mediaplayer-app
Diff against target: 24 lines (+12/-1)
1 file modified
snapcraft.yaml (+12/-1)
To merge this branch: bzr merge lp:~renatofilho/mediaplayer-app/no-uap-files
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Approve
Andrew Hayzen (community) Approve
Review via email: mp+321769@code.launchpad.net

Commit message

Avoid duplicated files from ubuntu-app-platform.
Update snap to install gst software codecs.

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:445
https://jenkins.canonical.com/system-apps/job/lp-mediaplayer-app-ci/4/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2398
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2398
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2210
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2210/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2210
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2210/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2210
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2210/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2210
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2210/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2210
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2210/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2210
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2210/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-mediaplayer-app-ci/4/rebuild

review: Approve (continuous-integration)
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:446
https://jenkins.canonical.com/system-apps/job/lp-mediaplayer-app-ci/5/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2399
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2399
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2211
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2211/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2211
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2211/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2211
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2211/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2211
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2211/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2211
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2211/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2211
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2211/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-mediaplayer-app-ci/5/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

When building there are things in /lib that appear in UAP's /lib
Such as:
libpng12.so.0

Before the whole of /etc was being removed? Is that required now? And there are stuff in /usr/share that is the same?

review: Needs Information
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

> When building there are things in /lib that appear in UAP's /lib
> Such as:
> libpng12.so.0
>
> Before the whole of /etc was being removed? Is that required now? And there
> are stuff in /usr/share that is the same?

Reverted these changes.

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

This looks better now.

When running there is only one warning I see:
(gst-plugin-scanner:29873): GStreamer-WARNING **: Failed to load plugin '/snap/mediaplayer-app/x1/ubuntu-app-platform/usr/lib/x86_64-linux-gnu/gstreamer-1.0/libgstaasink.so': libgpm.so.2: cannot open shared object file: No such file or directory

You can fix this by staging
- libgpm2

And adding allowing the path
- usr/lib/*/libgpm*

Not sure if it is really required as all it does is "handles mouse requests and delivers them to applications".

review: Approve
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:448
https://jenkins.canonical.com/system-apps/job/lp-mediaplayer-app-ci/6/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2400
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2400
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2212
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2212/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2212
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2212/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2212
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2212/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2212
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2212/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2212
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2212/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2212
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2212/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-mediaplayer-app-ci/6/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'snapcraft.yaml'
--- snapcraft.yaml 2017-04-03 21:25:05 +0000
+++ snapcraft.yaml 2017-04-03 21:45:50 +0000
@@ -53,8 +53,19 @@
53 - desktop-ubuntu-app-platform53 - desktop-ubuntu-app-platform
5454
55 snap:55 snap:
56 - -lib
57 - -etc
58 - -usr/lib/python*
59 - -usr/share/apport
60 - -usr/share/bug
61 - -usr/share/doc
62 - -usr/share/fonts
63 - -usr/share/libwacom
64 - -usr/share/lintian
65 - -usr/share/man
66 - -usr/share/X11
56 # ubuntu-app-platfrom files (avoid dubplicated).67 # ubuntu-app-platfrom files (avoid dubplicated).
57 # mantain full list to be easy to mantain68 # keep a full list to be easy to mantain
58 - -usr/lib/x86_64-linux-gnu/Mcrt1.o69 - -usr/lib/x86_64-linux-gnu/Mcrt1.o
59 - -usr/lib/x86_64-linux-gnu/Scrt1.o70 - -usr/lib/x86_64-linux-gnu/Scrt1.o
60 - -usr/lib/x86_64-linux-gnu/address-book-service/address-book-service71 - -usr/lib/x86_64-linux-gnu/address-book-service/address-book-service

Subscribers

People subscribed via source and target branches