Merge lp:~raof/mir/fix-invalid-bufferstream-id into lp:mir
Proposed by
Chris Halse Rogers
Status: | Merged |
---|---|
Approved by: | Gerry Boland |
Approved revision: | no longer in the source branch. |
Merged at revision: | 4178 |
Proposed branch: | lp:~raof/mir/fix-invalid-bufferstream-id |
Merge into: | lp:mir |
Prerequisite: | lp:~raof/mir/better-eglstream-detection |
Diff against target: |
23 lines (+0/-2) 2 files modified
src/client/mir_connection.cpp (+0/-1) tests/unit-tests/client/test_mir_connection.cpp (+0/-1) |
To merge this branch: | bzr merge lp:~raof/mir/fix-invalid-bufferstream-id |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gerry Boland (community) | Approve | ||
Alan Griffiths | Approve | ||
Mir CI Bot | continuous-integration | Approve | |
Review via email: mp+324600@code.launchpad.net |
Commit message
client: Don't set BufferStreamID to an invalid value when allocating a buffer.
We have code in mf::SessionMediator to check if a BufferStreamID is set on a allocation request. This code never exectues, though, because for some reason MirConnection will always set the BufferStreamID on an allocation request.
And if there isn't a reasonable BufferStreamID to set (ie: we're allocating a buffer via mir_connection_
To post a comment you must log in.
PASSED: Continuous integration, rev:4183 /mir-jenkins. ubuntu. com/job/ mir-ci/ 3412/ /mir-jenkins. ubuntu. com/job/ build-mir/ 4640 /mir-jenkins. ubuntu. com/job/ build-0- fetch/4772 /mir-jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= xenial+ overlay/ 4761 /mir-jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= zesty/4761 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= clang,platform= mesa,release= zesty/4672 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= clang,platform= mesa,release= zesty/4672/ artifact/ output/ *zip*/output. zip /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= gcc,platform= mesa,release= xenial+ overlay/ 4672 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= gcc,platform= mesa,release= xenial+ overlay/ 4672/artifact/ output/ *zip*/output. zip /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= gcc,platform= mesa,release= zesty/4672 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= gcc,platform= mesa,release= zesty/4672/ artifact/ output/ *zip*/output. zip /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= cross-armhf, compiler= gcc,platform= mesa,release= zesty/4672 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= cross-armhf, compiler= gcc,platform= mesa,release= zesty/4672/ artifact/ output/ *zip*/output. zip /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= i386,compiler= gcc,platform= mesa,release= xenial+ overlay/ 4672 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= i386,compiler= gcc,platform= mesa,release= xenial+ overlay/ 4672/artifact/ output/ *zip*/output. zip
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild: /mir-jenkins. ubuntu. com/job/ mir-ci/ 3412/rebuild
https:/