Merge lp:~ralph-bean/pylibravatar/tcp-dns into lp:pylibravatar
Status: | Merged |
---|---|
Merged at revision: | 37 |
Proposed branch: | lp:~ralph-bean/pylibravatar/tcp-dns |
Merge into: | lp:pylibravatar |
Diff against target: |
12 lines (+1/-1) 1 file modified
libravatar.py (+1/-1) |
To merge this branch: | bzr merge lp:~ralph-bean/pylibravatar/tcp-dns |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
François Marier | Approve | ||
Review via email: mp+263157@code.launchpad.net |
Commit message
Use TCP for SRV lookups
Description of the change
Use tcp for SRV lookups.
By default, the DNS module is using udp. I discovered this because it would
periodically time out on our server -- requests would sometimes take 30s that
would normally take less than 1s. I'd like to use tcp for our use case in
order to avoid timeouts. However, that alone is not reason enough to ask
everyone else to use tcp. They may want udp. It is faster, right?
While playing with this, I found that on average tcp is repeatably faster than
udp for these kinds of requests.
See tcp:
$ time python -c """
import DNS
DNS.DiscoverN
[DNS.
"""
python -c 0.10s user 0.03s system 10% cpu 1.270 total
Versus udp:
$ time python -c """
import DNS
DNS.DiscoverN
[DNS.
"""
python -c 0.24s user 0.11s system 3% cpu 9.514 total
Which makes it a more suitable default for libravatar.py, no?
Thanks!