Merge lp:~raharper/curtin/trunk.fix-lp1722322 into lp:~curtin-dev/curtin/trunk
Proposed by
Ryan Harper
Status: | Merged |
---|---|
Merged at revision: | 533 |
Proposed branch: | lp:~raharper/curtin/trunk.fix-lp1722322 |
Merge into: | lp:~curtin-dev/curtin/trunk |
Diff against target: |
66 lines (+29/-2) 3 files modified
curtin/commands/block_meta.py (+5/-1) examples/tests/uefi_basic.yaml (+23/-0) tests/vmtests/test_uefi_basic.py (+1/-1) |
To merge this branch: | bzr merge lp:~raharper/curtin/trunk.fix-lp1722322 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Scott Moser (community) | Approve | ||
Server Team CI bot | continuous-integration | Approve | |
Review via email: mp+332026@code.launchpad.net |
Description of the change
block_meta: use block.wipe_
In the case curtin is not directed to wipe the partition table via the
wipe: configuration, a disk may contain an MBR and sgdisk --clear does
not successfully wipe MBR tables. Replace the call to sgdisk with curtin
block.wipe_
LP: 1722322
To post a comment you must log in.
I would generally like to recreate this issue by pre-populating an image with an MBR such that the current sgdisk --clear blows up like it does in the bug.
While we do have the dirty-disks mode, that currently runs the same curtin storage config twice; but we really need to apply a separate storage config during the early stage, and then a different one at the normal install stage.