Merge ~raharper/curtin:fix/dname-warning-missing-serial into curtin:master
Proposed by
Ryan Harper
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Ryan Harper | ||||
Approved revision: | 2443c3613a2d1338b53fbbdcefeb4ac12994fa4d | ||||
Merge reported by: | Server Team CI bot | ||||
Merged at revision: | not available | ||||
Proposed branch: | ~raharper/curtin:fix/dname-warning-missing-serial | ||||
Merge into: | curtin:master | ||||
Diff against target: |
116 lines (+49/-12) 2 files modified
curtin/commands/block_meta.py (+4/-2) tests/unittests/test_make_dname.py (+45/-10) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Server Team CI bot | continuous-integration | Approve | |
Chad Smith | Approve | ||
Review via email: mp+362752@code.launchpad.net |
Commit message
dname: relax dname req for disk serial/wwn presence for compatibility
Allow disks without serial/wwn values to have dnames and do not raise
a RuntimeError exception which prevented legacy KVM pods from deploying
as their VM configuration lacked disk serial numbers. Per discussion
in the bug, prefer compatibility with these systems, allow dname to remain
unstable and provide a warning in the install log but do not fail
deployment. Update dname match attributes to: ID_WWN_
ID_WWN, ID_SERIAL, ID_SERIAL_SHORT.
LP: #1735839
To post a comment you must log in.
Started vmtest run on this:
https:/ /jenkins. ubuntu. com/server/ job/curtin- vmtest- devel-debug/ 143/console