Merge lp:~popey/ubuntu-weather-app/manual-tests into lp:ubuntu-weather-app

Status: Superseded
Proposed branch: lp:~popey/ubuntu-weather-app/manual-tests
Merge into: lp:ubuntu-weather-app
Diff against target: 252 lines (+232/-0)
4 files modified
tests/manual/weather-firstrun.pxu (+64/-0)
tests/manual/weather-forecasts.pxu (+57/-0)
tests/manual/weather-locations.pxu (+76/-0)
tests/manual/weather-settings.pxu (+35/-0)
To merge this branch: bzr merge lp:~popey/ubuntu-weather-app/manual-tests
Reviewer Review Type Date Requested Status
Victor Thompson Needs Fixing
Jenkins Bot continuous-integration Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Nicholas Skaggs (community) Needs Fixing
Review via email: mp+272733@code.launchpad.net

This proposal has been superseded by a proposal from 2015-12-16.

Commit message

Add manual tests

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

These are fine, but will need a provider and folder layout to make them plug and play. I'll bundle them and try them before providing a diff.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

These work. Some comments

Avoid using dashes for the file name
s/first-run/firstrun/

Prefix the tests file names with 'weather-'

You are missing a colon
s/_description/_description:/g

review: Needs Fixing
130. By Alan Pope 🍺🐧🐱 πŸ¦„

update based on feedback from balloons

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

See 1 inline comment.

Also:
1. Please add an entry to the changelog, we're trying to maintain this file as we make fixes/updates.
2. There seem to be a lot of indentation issues. Is that problematic at all? Will it show up in an odd fashion to those running through the tests?

review: Needs Fixing

Unmerged revisions

130. By Alan Pope 🍺🐧🐱 πŸ¦„

update based on feedback from balloons

129. By Alan Pope 🍺🐧🐱 πŸ¦„

Add manual tests

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added directory 'tests/manual'
=== added file 'tests/manual/weather-firstrun.pxu'
--- tests/manual/weather-firstrun.pxu 1970-01-01 00:00:00 +0000
+++ tests/manual/weather-firstrun.pxu 2015-09-29 23:44:36 +0000
@@ -0,0 +1,64 @@
1id: firstrun/check-icon
2plugin: manual
3_summary: Test to check correct icon is used
4estimated_duration: 600
5_description:
6 Test to check correct icon is used
7 1. Install weather reboot
8 Weather icon with a cloud and 12-spiked sun should appear in the dash
9
10id: firstrun/location-check
11plugin: manual
12_summary: Test to confirm location is requested
13estimated_duration: 600
14_description:
15 Test to confirm location is requested
16 1. Launch weather reboot
17 Expect to see 'location acceptance screen'
18
19id: firstrun/location-deny
20plugin: manual
21_summary: Test to confirm effect of denying location access
22estimated_duration: 600
23_description:
24 Test to confirm effect of denying location access
25 1. Launch weather reboot
26 Expect to see 'location acceptance screen'
27 2. Choose 'deny'
28 Expect to see the "Cannoy determine your location", "Manually add" screen
29
30id: firstrun/location-allow
31plugin: manual
32_summary: Test to confirm effect of allowing location access
33estimated_duration: 600
34_description:
35 Test to confirm effect of allowing location access
36 1. Close weather app (if already open)
37 2. Launch System Settings
38 3. Choose "Security & Privacy"
39 4. Choose "Location Access"
40 5. Switch location access for weather app on
41 This reverses the location denial from the previous test
42 6. Launch weather reboot
43 Expect to _not_ see 'location acceptance screen'
44 7. Wait for a short while
45 Expect to see weather for your current location
46
47id: firstrun/pull-refresh
48plugin: manual
49_summary: Test to confirm pull to refresh works
50estimated_duration: 600
51_description:
52 Test to confirm pull to refresh works
53 1. Launch weather reboot
54 Expect to see weather details for current location
55 2. Pull down the screen to refresh
56 Expect to see 'Pull down to refresh' then 'Release to refresh'
57 3. Let go of the screen
58 Expect view to refresh - although you may not see any difference if the data recently refreshed
59
60
61
62
63
64
065
=== added file 'tests/manual/weather-forecasts.pxu'
--- tests/manual/weather-forecasts.pxu 1970-01-01 00:00:00 +0000
+++ tests/manual/weather-forecasts.pxu 2015-09-29 23:44:36 +0000
@@ -0,0 +1,57 @@
1id: forecasts/test-daily-forecast
2plugin: manual
3_summary: Test to future day forecast is shown
4estimated_duration: 600
5_description:
6 Test to future day forecast is shown
7 1. Launch weather app
8 Expect to see weather for your current location
9 2. Scroll up
10 Expect to see weather for at least the following 4 days
11
12id: forecasts/test-hourly-forecast-detail
13plugin: manual
14_summary: Test to ensure hourly forecast detail is shown
15estimated_duration: 600
16_description:
17 Test to ensure hourly forecast detail is shown
18 1. Launch weather app
19 Expect to see weather for your current location
20 2. Tap large current weather icon (cloud/sun/rain) in the top half of the display
21 Expect to see weather for the following hours
22 3. Swipe right and left
23 Expect to see further details about the weather on coming hours
24 4. Tap in that area again
25 Expect the previously shown current weather icon to be displayed
26
27id: forecasts/test-daily-forecast-detail
28plugin: manual
29_summary: Test to ensure daily forecast detail is shown
30estimated_duration: 600
31_description:
32 Test to ensure daily forecast detail is shown
33 1. Launch weather app
34 Expect to see weather for your current location
35 2. Scroll up
36 Expect to see weather for at least the following 4 days
37 3. Tap any day in the future
38 Expect to see further details about the weather on that day
39 4. Tap any other day
40 Expect the previously tapped day to shrink, and the newly tapped day to expand
41 5. Tap the same day again
42 Expect the tapped day detail to shrink
43
44id: forecasts/test-final-day
45plugin: manual
46_summary: Test to ensure UI expands properly
47estimated_duration: 600
48_description:
49 Test to ensure UI expands properly
50 1. Launch weather app
51 Expect to see weather for your current location
52 2. Scroll up to the very bottom
53 Expect to see weather for at least the following 4 days
54 3. Tap the final day in the list
55 Expect it to expand, and still be on screen (i.e. not expanded off-screen)
56
57
058
=== added file 'tests/manual/weather-locations.pxu'
--- tests/manual/weather-locations.pxu 1970-01-01 00:00:00 +0000
+++ tests/manual/weather-locations.pxu 2015-09-29 23:44:36 +0000
@@ -0,0 +1,76 @@
1id: locations/show-list-of-locations
2plugin: manual
3_summary: Test to see a list of locations
4estimated_duration: 600
5_description:
6 Test to see a list of locations
7 1. Launch weather app
8 Expect to see weather for your current location
9 2. Swipe up from the bottom of the screen
10 Expect to see a list of locations (only one location on first run, or no locations if gps access denied)
11
12id: locations/add-pre-defined-location
13plugin: manual
14_summary: Test to add a location from a pre-defined list
15estimated_duration: 600
16_description:
17 Test to add a location from a pre-defined list
18 1. Launch weather app
19 Expect to see weather for your current location
20 2. Swipe up from the bottom of the screen
21 Expect to see a list of locations (only one location on first run, or no locations if gps access denied)
22 3. Press "+" icon
23 Expect to see a pre-defined list of city names
24 4. Tap any city on the list
25 Expect to see it added to the list of locations
26 5. Continue to add more cities
27 There is a hard wired limit of 7 locations currently
28
29id: locations/switch-location-by-swipe
30plugin: manual
31_summary: Test to switch locations by swiping
32estimated_duration: 600
33_description:
34 Test to switch locations by swiping
35 1. Launch weather app
36 Expect to see weather for your current location
37 2. Swipe left
38 Expect to switch location
39 3. Swipe right
40 Expect to switch back to previous location
41
42id: locations/switch-location-by-edge
43plugin: manual
44_summary: Test to switch locations using bottom edge
45estimated_duration: 600
46_description:
47 Test to switch locations using bottom edge
48 1. Launch weather app
49 Expect to see weather for your current location
50 2. Swipe up from the bottom of the screen
51 Expect to see a list of locations
52 3. Tap a location
53 Expect to be returned to the main screen, showing weather for selected location
54
55id: locations/delete-location
56plugin: manual
57_summary: Test to remove locations
58estimated_duration: 600
59_description:
60 Test to remove locations
61 1. Launch weather app
62 Expect to see weather for your current location
63 2. Swipe up from the bottom of the screen
64 Expect to see a list of locations
65 3. Swipe a location to the right
66 Expect to see a delete option
67 4. Swipe location left again
68 Expect location NOT to be deleted
69 5. Swipe a location to the right
70 Expect to see a delete option
71 6. Tap delete (trash) button
72 Expect location to be deleted
73
74
75
76
077
=== added file 'tests/manual/weather-settings.pxu'
--- tests/manual/weather-settings.pxu 1970-01-01 00:00:00 +0000
+++ tests/manual/weather-settings.pxu 2015-09-29 23:44:36 +0000
@@ -0,0 +1,35 @@
1id: settings/change-units-temp
2plugin: manual
3_summary: Test to change temperature units
4estimated_duration: 600
5_description:
6 Test to change temperature units
7 1. Launch weather app
8 Expect to see weather for your current location
9 2. Tap settings cog in top right corner
10 Expect to see a list of settings
11 3. Tap "Units"
12 Expect to see 'Units' screen
13 4. Tap "Temperature"
14 Expect to see options unfolded
15 5. Switch to different temperature units and go back to main screen
16 Expect units shown to be different
17
18id: settings/change-units-speed
19plugin: manual
20_summary: Test to change wind speed units
21estimated_duration: 600
22_description:
23 Test to change wind speed units
24 1. Launch weather app
25 Expect to see weather for your current location
26 2. Tap settings cog in top right corner
27 Expect to see a list of settings
28 3. Tap "Units"
29 Expect to see 'Units' screen
30 4. Tap "Wind Speed"
31 Expect to see options unfolded
32 5. Switch to different wind speed units and go back to main screen
33 Expect wind speed units shown to be different
34
35

Subscribers

People subscribed via source and target branches