Merge lp:~pmarchwiak/synapse-project/recoll-plugin into lp:synapse-project
Status: | Needs review |
---|---|
Proposed branch: | lp:~pmarchwiak/synapse-project/recoll-plugin |
Merge into: | lp:synapse-project |
Diff against target: |
217 lines (+191/-0) 3 files modified
src/plugins/Makefile.am (+1/-0) src/plugins/recoll-plugin.vala (+189/-0) src/ui/synapse-main.vala (+1/-0) |
To merge this branch: | bzr merge lp:~pmarchwiak/synapse-project/recoll-plugin |
Related bugs: | |
Related blueprints: |
Add a zotero plug-in for Synapse
(Undefined)
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michal Hruby | Pending | ||
Review via email: mp+133784@code.launchpad.net |
Description of the change
This plugin runs queries against a Recoll index providing search results based on file contents (document types supported by Recoll include msword and PDF).
Feature summary for the current implementation:
* returns up to 20 UriMatches, using the filename as the title and filename + abstract (sample of doc contents) as the description
* results are scored lower than results from the locate plugin to ensure file name matches show up first in the results
* plugin is only enabled when the recoll command is available
Unmerged revisions
- 511. By Patrick Marchwiak
-
Set the description to file name + abstract in recoll plugin
- 510. By Patrick Marchwiak
-
Turn down match score and use Utils.FileInfo to build better results in recoll plugin
- 509. By Patrick Marchwiak
-
Remove python script for accessing recoll and invoke cmd line tool directly
- 508. By Patrick Marchwiak
-
Add initial version of recoll plugin
Thanks for the contribution, it's looking pretty good, although I do have one gripe:
I'm not a fan of spawning processes in the search() method of an ItemProvider plugin - this is called on every keystroke and is pretty heavy on the system. That's why "Locate" is hidden behind an action, and before calculating with `bc` the query is first checked against a regex. Could you please do something like that?
Otherwise, the code is clean, nice job ;)