Merge lp:~pitti/unity-gtk-module/env-race into lp:unity-gtk-module

Proposed by Martin Pitt
Status: Merged
Approved by: Ted Gould
Approved revision: 340
Merged at revision: 339
Proposed branch: lp:~pitti/unity-gtk-module/env-race
Merge into: lp:unity-gtk-module
Diff against target: 51 lines (+4/-10)
4 files modified
data/Makefile.am (+0/-3)
data/unity-gtk-module.override (+0/-1)
data/unity-gtk-module.service (+2/-4)
debian/control (+2/-2)
To merge this branch: bzr merge lp:~pitti/unity-gtk-module/env-race
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+305613@code.launchpad.net

Commit message

Fix $GTK_MODULES race condition

Description of the change

Fix race condition in bug 1618886 and fix Vcs-* tags.

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/Makefile.am'
--- data/Makefile.am 2016-08-04 10:51:59 +0000
+++ data/Makefile.am 2016-09-13 15:03:34 +0000
@@ -10,7 +10,4 @@
10systemd_userunitdir = $(SYSTEMD_USERUNITDIR)10systemd_userunitdir = $(SYSTEMD_USERUNITDIR)
11systemd_userunit_DATA = unity-gtk-module.service11systemd_userunit_DATA = unity-gtk-module.service
1212
13upstart_systemd_overridedir = $(datadir)/upstart/systemd-session/upstart/
14upstart_systemd_override_DATA = unity-gtk-module.override
15
16EXTRA_DIST = $(dist_upstart_job_DATA)13EXTRA_DIST = $(dist_upstart_job_DATA)
1714
=== removed file 'data/unity-gtk-module.override'
--- data/unity-gtk-module.override 2016-08-03 16:01:11 +0000
+++ data/unity-gtk-module.override 1970-01-01 00:00:00 +0000
@@ -1,1 +0,0 @@
1manual
20
=== modified file 'data/unity-gtk-module.service'
--- data/unity-gtk-module.service 2016-08-03 16:01:11 +0000
+++ data/unity-gtk-module.service 2016-09-13 15:03:34 +0000
@@ -8,12 +8,10 @@
8RemainAfterExit=yes8RemainAfterExit=yes
9ExecStart=/bin/sh -ec '\9ExecStart=/bin/sh -ec '\
10 GTK_MODULES="$${GTK_MODULES:+$GTK_MODULES:}unity-gtk-module";\10 GTK_MODULES="$${GTK_MODULES:+$GTK_MODULES:}unity-gtk-module";\
11 dbus-update-activation-environment --verbose --systemd GTK_MODULES;\11 dbus-update-activation-environment --verbose --systemd GTK_MODULES'
12 initctl set-env --global GTK_MODULES=$${GTK_MODULES} || true'
13ExecStopPost=/bin/sh -ec '\12ExecStopPost=/bin/sh -ec '\
14 GTK_MODULES=$$(echo -n $${GTK_MODULES} | awk -v RS=: -v ORS=: "/^unity-gtk-module$/ {next} {print}" | sed -e "s/:*$//");\13 GTK_MODULES=$$(echo -n $${GTK_MODULES} | awk -v RS=: -v ORS=: "/^unity-gtk-module$/ {next} {print}" | sed -e "s/:*$//");\
15 dbus-update-activation-environment --verbose --systemd GTK_MODULES;\14 dbus-update-activation-environment --verbose --systemd GTK_MODULES'
16 initctl set-env --global GTK_MODULES=$${GTK_MODULES} || true'
1715
18[Install]16[Install]
19WantedBy=ubuntu-session.target17WantedBy=ubuntu-session.target
2018
=== modified file 'debian/control'
--- debian/control 2016-08-04 10:51:59 +0000
+++ debian/control 2016-09-13 15:03:34 +0000
@@ -13,8 +13,8 @@
13# If you aren't a member of ~indicator-applet-developers but need to upload13# If you aren't a member of ~indicator-applet-developers but need to upload
14# packaging changes, just go ahead. ~indicator-applet-developers will notice14# packaging changes, just go ahead. ~indicator-applet-developers will notice
15# and sync up the code again.15# and sync up the code again.
16Vcs-Bzr: https://code.launchpad.net/~indicator-applet-developers/unity-gtk-module/trunk16Vcs-Bzr: https://code.launchpad.net/~indicator-applet-developers/unity-gtk-module/trunk.15.04
17Vcs-Browser: https://bazaar.launchpad.net/~indicator-applet-developers/unity-gtk-module/trunk/files17Vcs-Browser: https://bazaar.launchpad.net/~indicator-applet-developers/unity-gtk-module/trunk.15.04
1818
19Package: libunity-gtk-parser-dev-common19Package: libunity-gtk-parser-dev-common
20Section: libdevel20Section: libdevel

Subscribers

People subscribed via source and target branches