Merge lp:~pitti/autopilot-gtk/enum-flags-properties into lp:autopilot-gtk
Proposed by
Martin Pitt
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Martin Pitt | ||||
Approved revision: | 49 | ||||
Merged at revision: | 47 | ||||
Proposed branch: | lp:~pitti/autopilot-gtk/enum-flags-properties | ||||
Merge into: | lp:autopilot-gtk | ||||
Diff against target: |
174 lines (+86/-50) 2 files modified
lib/GtkNode.cpp (+71/-45) tests/autopilot/tests/test_properties.py (+15/-5) |
||||
To merge this branch: | bzr merge lp:~pitti/autopilot-gtk/enum-flags-properties | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Thomi Richards (community) | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email: mp+171713@code.launchpad.net |
Commit message
Handle enum and flags properties. (LP: #1193342)
Description of the change
This branch enables enum and flag properties, such as GtkButton.relief or
GtkWidget.events. The first commit refactors the MatchProperty() method, to avoid having to introduce more duplicated code, and fix the GValue leak. After that, introducing support for new property types is a matter of only adding them to the convert_value() helper function, and then introspecting and matching will both support it.
To post a comment you must log in.
PASSED: Continuous integration, rev:49 jenkins. qa.ubuntu. com/job/ autopilot- gtk-ci/ 57/ jenkins. qa.ubuntu. com/job/ autopilot- gtk-saucy- amd64-ci/ 19 jenkins. qa.ubuntu. com/job/ autopilot- gtk-saucy- armhf-ci/ 19
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ autopilot- gtk-ci/ 57/rebuild
http://