Merge lp:~piastucki/bzr-xmloutput/fix-auth into lp:bzr-xmloutput
Status: | Superseded |
---|---|
Proposed branch: | lp:~piastucki/bzr-xmloutput/fix-auth |
Merge into: | lp:bzr-xmloutput |
Diff against target: |
230 lines (+161/-9) 5 files modified
service.py (+17/-9) tests/__init__.py (+2/-0) tests/test_auth_service.py (+68/-0) tests/test_uifactory.py (+23/-0) uifactory.py (+51/-0) |
To merge this branch: | bzr merge lp:~piastucki/bzr-xmloutput/fix-auth |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Guillermo Gonzalez | Needs Fixing | ||
Review via email: mp+148877@code.launchpad.net |
This proposal has been superseded by a proposal from 2013-02-23.
Commit message
This commit introduces a custom UIFactory that handles get_password() and get_username() to avoid XMLRPC server hanging on waiting for user's input.
When 'run_bzr' function is invoked ValueError will be thrown whenever get_password() or get_username() is called to avoid server hang and to allow the client to ask the user for credentials.
Additionally, a new function 'run_bzr_auth' was added to make it possible to pass username and password to be used instead of throwing the error.
Description of the change
This commit introduces a custom UIFactory that handles get_password() and get_username() to avoid XMLRPC server hanging on waiting for user's input.
When 'run_bzr' function is invoked ValueError will be thrown whenever get_password() or get_username() is called to avoid server hang and to allow the client to ask the user for credentials.
Additionally, a new function 'run_bzr_auth' was added to make it possible to pass username and password to be used instead of throwing the error.
The changes looks good.
Could you add some tests checking the behavior of the UIFactory? Also, please could you add tests for at least the 2 cases with the new "auth" command?
Thanks.