Merge lp:~phablet-team/telephony-service/sms-notif-lp1544477 into lp:telephony-service

[Alfonso Sanchez-Beato]

Make sure we play notification sounds if media-hub re-starts
(LP: #1544477).

Make sure we play notification sounds if media-hub re-starts
(LP: #1544477).

[Gustavo Pichorim Boiko (boiko)]

Looks good!

review: Approve

[Jim Hodapp (jhodapp)]

review: Needs Fixing (code)

[lp:~phablet-team/telephony-service/sms-notif-lp1544477]

1202. By Alfonso Sanchez-Beato on 2016-08-23

Fix style issue

[Jim Hodapp (jhodapp)]

review: Approve (code)

=== modified file 'libtelephonyservice/ringtone.cpp'
--- libtelephonyservice/ringtone.cpp	2016-03-21 19:05:02 +0000
+++ libtelephonyservice/ringtone.cpp	2016-08-23 14:43:38 +0000
@@ -72,6 +72,16 @@
         return;
     }
 
+    // Re-create if in error state. A typical case is when media-hub-server has
+    // crashed and we need to start from a clean slate.
+    if (mMessageAudioPlayer && mMessageAudioPlayer->error()) {
+        qDebug() << "mMessageAudioPlayer in error state ("
+                 << mMessageAudioPlayer->error() << "), recreating";
+
+        mMessageAudioPlayer->deleteLater();
+        mMessageAudioPlayer = NULL;
+    }
+
     if (!mMessageAudioPlayer) {
         mMessageAudioPlayer = new QMediaPlayer(this);
         mMessageAudioPlayer->setAudioRole(QAudio::NotificationRole);