Merge lp:~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp into lp:~hr-core-editors/hr-timesheet/7.0

[Pedro Manuel Baeza]

[FIX] hr_timesheet_sheet: Fix error if there is no project associated to task.
[FIX] hr_timesheet_sheet: Tree view for hr.analytic.timesheet inherited instead of overwritten, to allow other modules to modifiy this view (for example, hr_timesheet_department).
[IMP] hr_timesheet_sheet: Remove obsolete type labels on XML views.

[Stéphane Bidoul (Acsone) (sbi)]

Hello Pedro,

Can you explain the use case where you need to enter time on tasks in other state than done?

Domains such as this one may vary from a company to another, but I thought allowing only open tasks was a good default?

Thanks!

review: Needs Information (code review)

[Pedro Manuel Baeza (pedro.baeza)]

I think now in two possible scenarios:

- Bad configured project provokes that initial state of a task is not set.
- There is a third person that inputs all times. I'm thinking now that tasks can be also even in done state, because inputation is done afterwards.

Do you think there is a better way?

Regards.

[Stéphane Bidoul (Acsone) (sbi)]

In that case I would change de domain in an additional module that is perhaps specific to your use case, because I believe current users of hr_timesheet_task expect to see only open tasks.

review: Needs Fixing

[lp:~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp]

65. By Pedro Manuel Baeza on 2014-05-16

Domain of task field reverted to original state.

[Pedro Manuel Baeza (pedro.baeza)]

I have reverted back to original domain. Please review rest of the changes.

Regards.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

LGTM

review: Approve (code review, no test)

[Stéphane Bidoul (Acsone) (sbi)]

review: Approve (code review, no test)

=== modified file 'hr_timesheet_task/hr_analytic_timesheet_view.xml'
--- hr_timesheet_task/hr_analytic_timesheet_view.xml	2013-04-10 16:14:47 +0000
+++ hr_timesheet_task/hr_analytic_timesheet_view.xml	2014-05-16 13:48:18 +0000
@@ -1,56 +1,35 @@
 <openerp>
     <data>
-        #---------------------------------------------------------------------------------------------------------
-        # Add task on hr.analytic.timesheet
-        #---------------------------------------------------------------------------------------------------------
-            <record id="hr_timesheet_line_form" model="ir.ui.view">
+        <!-- Add task on hr.analytic.timesheet -->
+        <record id="hr_timesheet_line_form" model="ir.ui.view">
             <field name="name">hr.analytic.timesheet.form</field>
             <field name="model">hr.analytic.timesheet</field>
-            <field name="type">form</field>
             <field name="inherit_id" ref="hr_timesheet.hr_timesheet_line_form"/>
             <field name="arch" type="xml">
                 <field name="user_id" position="after">
-                    <field name="task_id" context="{ 'account_id' : account_id}"
-                        domain="[('state','=','open'), ('project_id.analytic_account_id','=',account_id)]"/>
+                    <field name="task_id"
+                            context="{'account_id': account_id}"
+                            domain="[('state', '=', 'open'), ('project_id.analytic_account_id','=',account_id)]"/>
                 </field>
             </field>
         </record>
-        <record id="hr_timesheet.hr_timesheet_line_tree" model="ir.ui.view">
+        <record id="hr_timesheet_line_tree" model="ir.ui.view">
             <field name="name">hr.analytic.timesheet.tree</field>
             <field name="model">hr.analytic.timesheet</field>
-            <field name="type">tree</field>
-            <field name="priority">2</field>
+            <field name="inherit_id" ref="hr_timesheet.hr_timesheet_line_tree"/>
             <field name="arch" type="xml">
-                <tree editable="top" string="Timesheet Lines">
-                    <field name="date" on_change="on_change_date(date)"/>
-                    <field domain="[('type','=','normal'), ('state','=','open')]" name="account_id"/>
-                    <field name="task_id" context="{'account_id' : account_id}"
-                        domain="[('state','=','open'), ('project_id.analytic_account_id','=',account_id)]"/>
-                    <field name="name"/>
-                    <field name="unit_amount"
-                        on_change="on_change_unit_amount(product_id, unit_amount, False, product_uom_id, journal_id)"
-                        sum="Total time" widget="float_time"/>
-                    <field name="user_id" on_change="on_change_user_id(user_id)" required="1"/>
-                    <field name="journal_id" invisible="1"/>
-                    <field name="product_id"
-                        on_change="on_change_unit_amount(product_id, unit_amount, False, product_uom_id, journal_id)"
-                        required="1" domain="[('type','=','service')]" invisible="1"/>
-                    <field name="product_uom_id"
-                        on_change="on_change_unit_amount(product_id, unit_amount, False, product_uom_id, journal_id)"
-                        invisible="1"/>
-                    <field name="amount" sum="Total cost" invisible="1"/>
-                    <field name="general_account_id" invisible="1"/>
-                </tree>
+                <field name="account_id" position="after">
+                    <field name="task_id"
+                            context="{'account_id': account_id}"
+                            domain="[('state', '=', 'open'), ('project_id.analytic_account_id','=',account_id)]"/>
+                </field>
             </field>
         </record>
-        #---------------------------------------------------------------------------------------------------------
-        # Add task on search hr.analytic.timesheet
-        #---------------------------------------------------------------------------------------------------------
-            <record id="hr_timesheet_line_search" model="ir.ui.view">
+        <!-- Add task on search hr.analytic.timesheet -->
+        <record id="hr_timesheet_line_search" model="ir.ui.view">
             <field name="name">hr.analytic.timesheet.search</field>
             <field name="model">hr.analytic.timesheet</field>
             <field name="inherit_id" ref="hr_timesheet.hr_timesheet_line_search"/>
-            <field name="type">search</field>
             <field name="arch" type="xml">
                 <field name="date" position="after">
                     <field name="task_id"/>
 
=== modified file 'hr_timesheet_task/hr_timesheet_sheet_view.xml'
--- hr_timesheet_task/hr_timesheet_sheet_view.xml	2013-03-28 17:30:55 +0000
+++ hr_timesheet_task/hr_timesheet_sheet_view.xml	2014-05-16 13:48:18 +0000
@@ -6,7 +6,6 @@
             <field name="name">hr_timesheet_sheet.sheet.filter</field>
             <field name="model">hr_timesheet_sheet.sheet</field>
             <field name="inherit_id" ref="hr_timesheet_sheet.view_hr_timesheet_sheet_filter"/>
-            <field name="type">search</field>
             <field name="arch" type="xml">
                 <filter name="to_approve" position="after">
                     <separator orientation="vertical"/>
 
=== modified file 'timesheet_task/project_task.py'
--- timesheet_task/project_task.py	2014-05-06 08:36:59 +0000
+++ timesheet_task/project_task.py	2014-05-16 13:48:18 +0000
@@ -58,8 +58,9 @@
         # project triggers on task are not called
         res = super(ProjectTask, self)._store_set_values(cr, uid, ids, fields, context=context)
         for row in self.browse(cr, SUPERUSER_ID, ids, context=context):
-            project = row.project_id
-            project.write({'parent_id': project.parent_id.id})
+            if row.project_id:
+                project = row.project_id
+                project.write({'parent_id': project.parent_id.id})
         return res