Merge lp:~pconnell/endroid/pinger into lp:endroid
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Paul Stanley | ||||
Approved revision: | 102 | ||||
Merged at revision: | 98 | ||||
Proposed branch: | lp:~pconnell/endroid/pinger | ||||
Merge into: | lp:endroid | ||||
Diff against target: |
88 lines (+28/-11) 4 files modified
debian/changelog (+8/-0) etc/init/endroid.conf (+1/-1) setup.py (+1/-1) src/endroid/plugins/periodicpinger.py (+18/-9) |
||||
To merge this branch: | bzr merge lp:~pconnell/endroid/pinger | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Phil Connell | Approve | ||
Review via email: mp+238291@code.launchpad.net |
This proposal supersedes a proposal from 2014-10-14.
Commit message
Improve reliability of periodic pinger
- Handle failures in wokkel/twisted (endroid bug 1380972)
- Log unexpected async errors for triageability
- Use addCallbacks so that errback is actually called!
Also tweak debian service file to log messages from twisted using the logging infra (rather than stderr).
Description of the change
Edit:
- Tweak debian service config file, so that messages from twisted (e.g. unhandled deferred failure) are logged.
- Fix bug in ping error handling.
- Log StanzaErrors as debug rather than errors.
Improve reliability of periodic pinger
- Handle failures in wokkel/twisted (endroid bug 1380972)
- Log async errors for triageability
- Use addCallbacks so that errback is actually called!
Ping to webex conference server *always* fails, so unconditional move to error logging in errback is no good.
root DEBUG Failed to ping conference. isj3.webex. com: StanzaError with condition u'bad-request'"