Merge lp:~pawciobiel/testdrive/1171045-fix-typo-parallels into lp:testdrive

Proposed by pawciobiel
Status: Merged
Merged at revision: 450
Proposed branch: lp:~pawciobiel/testdrive/1171045-fix-typo-parallels
Merge into: lp:testdrive
Diff against target: 33 lines (+3/-3)
2 files modified
bin/testdrive (+2/-2)
bin/testdrive-gtk (+1/-1)
To merge this branch: bzr merge lp:~pawciobiel/testdrive/1171045-fix-typo-parallels
Reviewer Review Type Date Requested Status
Andres Rodriguez Approve
Review via email: mp+234566@code.launchpad.net

Description of the change

fix typo bug lp:1171045

To post a comment you must log in.
Revision history for this message
pawciobiel (pawciobiel) wrote :

I thought for now we could just fix the typo here quickly and drop support for "parallels" in some other ticket, what do you reckon?

Revision history for this message
Jackson Doak (noskcaj) wrote :

Since no one's actively working on testdrive, just bugfix stuff, it's very
appreciated that you made the fix.

On Sat, Sep 13, 2014 at 8:24 PM, pawciobiel <email address hidden> wrote:

> I thought for now we could just fix the typo here quickly and drop support
> for "parallels" in some other ticket, what do you reckon?
> --
>
> https://code.launchpad.net/~pawciobiel/testdrive/1171045-fix-typo-parallels/+merge/234566
> Your team testdrive is requested to review the proposed merge of
> lp:~pawciobiel/testdrive/1171045-fix-typo-parallels into lp:testdrive.
>

Revision history for this message
pawciobiel (pawciobiel) wrote :

cheers!

Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/testdrive'
--- bin/testdrive 2013-10-24 02:11:50 +0000
+++ bin/testdrive 2014-09-13 10:22:38 +0000
@@ -264,7 +264,7 @@
264 logger.info(_("Using KVM for virtual machine hosting..."));264 logger.info(_("Using KVM for virtual machine hosting..."));
265 elif td.VIRT == "virtualbox":265 elif td.VIRT == "virtualbox":
266 logger.info(_("Using VirtualBox for virtual machine hosting..."))266 logger.info(_("Using VirtualBox for virtual machine hosting..."))
267 elif td.VIRT == "paralels":267 elif td.VIRT == "parallels":
268 logger.info(_("Using Parallels Desktop for virtual machine hosting..."))268 logger.info(_("Using Parallels Desktop for virtual machine hosting..."))
269269
270 ##########################################270 ##########################################
@@ -392,7 +392,7 @@
392 virt = kvm.KVM(td)392 virt = kvm.KVM(td)
393 if td.VIRT == "virtualbox":393 if td.VIRT == "virtualbox":
394 virt = virtualbox.VBox(td)394 virt = virtualbox.VBox(td)
395 if td.VIRT == "paralels":395 if td.VIRT == "parallels":
396 virt = parallels.Parallels(td)396 virt = parallels.Parallels(td)
397397
398 ###################398 ###################
399399
=== modified file 'bin/testdrive-gtk'
--- bin/testdrive-gtk 2013-11-17 08:19:27 +0000
+++ bin/testdrive-gtk 2014-09-13 10:22:38 +0000
@@ -739,7 +739,7 @@
739 if self.td.VIRT == "virtualbox":739 if self.td.VIRT == "virtualbox":
740 logging.info(_("Using VirtualBox for virtual machine hosting..."))740 logging.info(_("Using VirtualBox for virtual machine hosting..."))
741 virt = virtualbox.VBox(self.td)741 virt = virtualbox.VBox(self.td)
742 if self.td.VIRT == "paralels":742 if self.td.VIRT == "parallels":
743 logging.info(_("Using Parallels Desktop for virtual machine hosting..."))743 logging.info(_("Using Parallels Desktop for virtual machine hosting..."))
744 virt = parallels.Parallels(self.td)744 virt = parallels.Parallels(self.td)
745745

Subscribers

People subscribed via source and target branches