Merge lp:~paulliu/unity8/reboot_140728 into lp:unity8

Proposed by Ying-Chun Liu
Status: Merged
Approved by: Michał Sawicz
Approved revision: 1097
Merged at revision: 1167
Proposed branch: lp:~paulliu/unity8/reboot_140728
Merge into: lp:unity8
Diff against target: 126 lines (+21/-25)
1 file modified
qml/Components/Dialogs.qml (+21/-25)
To merge this branch: bzr merge lp:~paulliu/unity8/reboot_140728
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Michał Sawicz Approve
Albert Astals Cid (community) Needs Information
Review via email: mp+228485@code.launchpad.net

Commit message

Add button colors and i18n for power off dialog.

Description of the change

* Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
Jounih.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ying-Chun Liu (paulliu) wrote :
Revision history for this message
Ying-Chun Liu (paulliu) wrote :
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Text conflict in qml/Shell.qml
1 conflicts encountered.

review: Needs Fixing
Revision history for this message
Ying-Chun Liu (paulliu) wrote :

I'll need more time to figure out the trunk changings.

Revision history for this message
Ying-Chun Liu (paulliu) wrote :

Merged.

Revision history for this message
Albert Astals Cid (aacid) :
review: Abstain
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
lp:~paulliu/unity8/reboot_140728 updated
1092. By Ying-Chun Liu

merge trunk

1093. By Ying-Chun Liu

Don't show dialog when display power is off

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
lp:~paulliu/unity8/reboot_140728 updated
1094. By Ying-Chun Liu

Merge trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

19 if (!powerKeyTimer.running) {
20 - powerKeyTimer.start();
21 + powerKeyTimer.restart();
22 }

I don't understand this, if it's not runnign start and restart will do the same, no?

The Restart button is gone altogether?

review: Needs Information
Revision history for this message
Michał Sawicz (saviq) wrote :

W dniu 05.08.2014 o 13:29, Albert Astals Cid pisze:
> I don't understand this, if it's not runnign start and restart will do the same, no?

Yeah, but we only do the if(running) because of the bug above.

> The Restart button is gone altogether?

Yeah, no one reboots their phones ;)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Please add i18n.tr() to all the strings in the dialog.

review: Needs Fixing
lp:~paulliu/unity8/reboot_140728 updated
1095. By Ying-Chun Liu

Add i18n to all the dialog texts

1096. By Ying-Chun Liu

Merge upstream

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Please delete tag 7.85+14.10.20140428.2-0ubuntu1 in this branch and any local checkouts you might have.

review: Needs Fixing
Revision history for this message
Ying-Chun Liu (paulliu) wrote :

> Please delete tag 7.85+14.10.20140428.2-0ubuntu1 in this branch and any local
> checkouts you might have.
Done.

Revision history for this message
Michał Sawicz (saviq) wrote :

See inline.

review: Needs Fixing
lp:~paulliu/unity8/reboot_140728 updated
1097. By Ying-Chun Liu

Fix messages.
Remove disable when screen status changed

Revision history for this message
Michał Sawicz (saviq) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes.

 * Did CI run pass? If not, please explain why.
No, unrelated failures fixed in other branches.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'qml/Components/Dialogs.qml'
--- qml/Components/Dialogs.qml 2014-07-29 14:07:04 +0000
+++ qml/Components/Dialogs.qml 2014-08-15 14:28:27 +0000
@@ -18,15 +18,18 @@
1818
19import Unity.Application 0.119import Unity.Application 0.1
20import Unity.Session 0.120import Unity.Session 0.1
21import Ubuntu.Components 0.121import Ubuntu.Components 1.1
22import Ubuntu.Components.Popups 0.122import Ubuntu.Components.Popups 0.1
2323
24Item {24Item {
25 id: root25 id: root
2626
27 function onPowerKeyPressed() {27 function onPowerKeyPressed() {
28 // FIXME: event.isAutoRepeat is always false on Nexus 4.
29 // So we use powerKeyTimer.running to avoid the PowerOff key repeat
30 // https://launchpad.net/bugs/1349416
28 if (!powerKeyTimer.running) {31 if (!powerKeyTimer.running) {
29 powerKeyTimer.start();32 powerKeyTimer.restart();
30 }33 }
31 }34 }
3235
@@ -64,17 +67,17 @@
64 id: logoutDialog67 id: logoutDialog
65 Dialog {68 Dialog {
66 id: dialogueLogout69 id: dialogueLogout
67 title: "Logout"70 title: i18n.tr("Log out")
68 text: "Are you sure that you want to logout?"71 text: i18n.tr("Are you sure you want to log out?")
69 Button {72 Button {
70 text: "Cancel"73 text: i18n.tr("No")
71 onClicked: {74 onClicked: {
72 PopupUtils.close(dialogueLogout);75 PopupUtils.close(dialogueLogout);
73 d.dialogShown = false;76 d.dialogShown = false;
74 }77 }
75 }78 }
76 Button {79 Button {
77 text: "Yes"80 text: i18n.tr("Yes")
78 onClicked: {81 onClicked: {
79 DBusUnitySessionService.Logout();82 DBusUnitySessionService.Logout();
80 PopupUtils.close(dialogueLogout);83 PopupUtils.close(dialogueLogout);
@@ -88,17 +91,17 @@
88 id: shutdownDialog91 id: shutdownDialog
89 Dialog {92 Dialog {
90 id: dialogueShutdown93 id: dialogueShutdown
91 title: "Shutdown"94 title: i18n.tr("Shut down")
92 text: "Are you sure that you want to shutdown?"95 text: i18n.tr("Are you sure you want to shut down?")
93 Button {96 Button {
94 text: "Cancel"97 text: i18n.tr("No")
95 onClicked: {98 onClicked: {
96 PopupUtils.close(dialogueShutdown);99 PopupUtils.close(dialogueShutdown);
97 d.dialogShown = false;100 d.dialogShown = false;
98 }101 }
99 }102 }
100 Button {103 Button {
101 text: "Yes"104 text: i18n.tr("Yes")
102 onClicked: {105 onClicked: {
103 dBusUnitySessionServiceConnection.closeAllApps();106 dBusUnitySessionServiceConnection.closeAllApps();
104 DBusUnitySessionService.Shutdown();107 DBusUnitySessionService.Shutdown();
@@ -113,17 +116,17 @@
113 id: rebootDialog116 id: rebootDialog
114 Dialog {117 Dialog {
115 id: dialogueReboot118 id: dialogueReboot
116 title: "Reboot"119 title: i18n.tr("Reboot")
117 text: "Are you sure that you want to reboot?"120 text: i18n.tr("Are you sure you want to reboot?")
118 Button {121 Button {
119 text: "Cancel"122 text: i18n.tr("No")
120 onClicked: {123 onClicked: {
121 PopupUtils.close(dialogueReboot)124 PopupUtils.close(dialogueReboot)
122 d.dialogShown = false;125 d.dialogShown = false;
123 }126 }
124 }127 }
125 Button {128 Button {
126 text: "Yes"129 text: i18n.tr("Yes")
127 onClicked: {130 onClicked: {
128 dBusUnitySessionServiceConnection.closeAllApps();131 dBusUnitySessionServiceConnection.closeAllApps();
129 DBusUnitySessionService.Reboot();132 DBusUnitySessionService.Reboot();
@@ -138,8 +141,8 @@
138 id: powerDialog141 id: powerDialog
139 Dialog {142 Dialog {
140 id: dialoguePower143 id: dialoguePower
141 title: "Power"144 title: i18n.tr("Power")
142 text: i18n.tr("Are you sure you would like to turn power off?")145 text: i18n.tr("Are you sure you would like\nto power off?")
143 Button {146 Button {
144 text: i18n.tr("Power off")147 text: i18n.tr("Power off")
145 onClicked: {148 onClicked: {
@@ -148,15 +151,7 @@
148 d.dialogShown = false;151 d.dialogShown = false;
149 root.powerOffClicked();152 root.powerOffClicked();
150 }153 }
151 }154 color: UbuntuColors.red
152 Button {
153 text: i18n.tr("Restart")
154 onClicked: {
155 dBusUnitySessionServiceConnection.closeAllApps();
156 DBusUnitySessionService.Reboot();
157 PopupUtils.close(dialoguePower);
158 d.dialogShown = false;
159 }
160 }155 }
161 Button {156 Button {
162 text: i18n.tr("Cancel")157 text: i18n.tr("Cancel")
@@ -164,6 +159,7 @@
164 PopupUtils.close(dialoguePower);159 PopupUtils.close(dialoguePower);
165 d.dialogShown = false;160 d.dialogShown = false;
166 }161 }
162 color: UbuntuColors.coolGrey
167 }163 }
168 }164 }
169 }165 }

Subscribers

People subscribed via source and target branches