Merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba

Proposed by Paul J. Lucas
Status: Merged
Approved by: Paul J. Lucas
Approved revision: 11221
Merged at revision: 11462
Proposed branch: lp:~paul-lucas/zorba/pjl-misc
Merge into: lp:zorba
Diff against target: 12 lines (+1/-1)
1 file modified
src/zorbautils/locale.cpp (+1/-1)
To merge this branch: bzr merge lp:~paul-lucas/zorba/pjl-misc
Reviewer Review Type Date Requested Status
Federico Cavalieri Approve
Paul J. Lucas Approve
Review via email: mp+164563@code.launchpad.net

Commit message

Fix the use of setlocale(3) in locale.cpp reported by Federico Cavalieri.

Description of the change

Fix the use of setlocale(3) in locale.cpp reported by Federico Cavalieri.

To post a comment you must log in.
Revision history for this message
Paul J. Lucas (paul-lucas) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job pjl-misc-2013-05-18T01-09-42.757Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1 Approve.

Revision history for this message
Federico Cavalieri (fcavalieri) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job pjl-misc-2013-05-20T15-41-42.269Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/zorbautils/locale.cpp'
--- src/zorbautils/locale.cpp 2013-04-02 21:40:03 +0000
+++ src/zorbautils/locale.cpp 2013-05-18 00:55:30 +0000
@@ -233,7 +233,7 @@
233 //233 //
234 // Try the environment locale first.234 // Try the environment locale first.
235 //235 //
236 char const *loc = filter_useless_locale( ::setlocale( LC_ALL, "" ) );236 char const *loc = filter_useless_locale( ::setlocale( LC_ALL, nullptr ) );
237 if ( !loc ) {237 if ( !loc ) {
238 //238 //
239 // Try the "LANG" environment variable second.239 // Try the "LANG" environment variable second.

Subscribers

People subscribed via source and target branches