Merge lp:~pataquets/ubuntu/precise/avidemux/avidemux-bug-1041144 into lp:ubuntu/precise/avidemux

Proposed by pataquets
Status: Work in progress
Proposed branch: lp:~pataquets/ubuntu/precise/avidemux/avidemux-bug-1041144
Merge into: lp:ubuntu/precise/avidemux
Diff against target: 26 lines (+7/-1)
2 files modified
avidemux2-gtk.desktop (+1/-1)
debian/changelog (+6/-0)
To merge this branch: bzr merge lp:~pataquets/ubuntu/precise/avidemux/avidemux-bug-1041144
Reviewer Review Type Date Requested Status
Marc Deslauriers Needs Fixing
Ubuntu branches Pending
Review via email: mp+121341@code.launchpad.net

Commit message

Allow avidemux2_gtk to be selected from 'Open with' tab (LP: #1041144)

Description of the change

Add %U to Exec[$e] line to allow avidemux2_gtk binary to be listed in 'Open with' program list

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Thanks for your work here, some comments:

- The format is 3.0 (quilt), so instead of modifying files in-place you should create a quilt patch (like done in lp:ubuntu/avidemux).
- Did you discuss this change with upstream?

Revision history for this message
pataquets (pataquets) wrote :

I'm a newbie packager, no idea what a quilt patch is :s . Patch in Avidemux has been enhanced/made compliant by Luke.
BTW, no contact with upstream done. Should Ubuntu fixes be done upstream first? I have no idea on policies regarding this.
I've done this patch applying advice given in #ubuntu-bugs for a recent patch to lp:precise/mumble SRU.

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Thanks for the merge request, but the desktop file needs to be modified using the patch system that's in the package. See the following page for more information on patch systems:

http://developer.ubuntu.com/packaging/html/patches-to-packages.html

review: Needs Fixing

Unmerged revisions

54. By pataquets

Add changelog entry.

53. By pataquets

Allow avidemux2_gtk to be selected from 'Open with' tab

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'avidemux2-gtk.desktop'
--- avidemux2-gtk.desktop 2009-02-17 23:41:46 +0000
+++ avidemux2-gtk.desktop 2013-05-15 20:25:29 +0000
@@ -2,7 +2,7 @@
2Categories=GTK;AudioVideo2Categories=GTK;AudioVideo
3Comment=Per editar els vostres vídeos3Comment=Per editar els vostres vídeos
4Comment[ca]=Per editar els vostres vídeos4Comment[ca]=Per editar els vostres vídeos
5Exec[$e]=avidemux2_gtk5Exec[$e]=avidemux2_gtk %U
6GenericName=Video Editor (GTK+)6GenericName=Video Editor (GTK+)
7GenericName[ca]=Editor de vídeo (GTK+)7GenericName[ca]=Editor de vídeo (GTK+)
8Icon=avidemux8Icon=avidemux
99
=== modified file 'debian/changelog'
--- debian/changelog 2012-02-09 15:38:52 +0000
+++ debian/changelog 2013-05-15 20:25:29 +0000
@@ -1,3 +1,9 @@
1avidemux (1:2.5.4-0ubuntu11.1) precise; urgency=low
2
3 * Allow avidemux2_gtk to be selected from 'Open with' tab (LP: #1041144)
4
5 -- pataquets <pataquets@gmail.com> Wed, 15 May 2013 21:36:47 +0200
6
1avidemux (1:2.5.4-0ubuntu11) precise; urgency=low7avidemux (1:2.5.4-0ubuntu11) precise; urgency=low
28
3 * No-change rebuild to pick libvpx's new shlib. (LP: #926580)9 * No-change rebuild to pick libvpx's new shlib. (LP: #926580)

Subscribers

People subscribed via source and target branches

to all changes: