Merge lp:~osomon/webbrowser-app/fix-webview-height-landscape into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 375
Merged at revision: 376
Proposed branch: lp:~osomon/webbrowser-app/fix-webview-height-landscape
Merge into: lp:webbrowser-app
Diff against target: 12 lines (+1/-1)
1 file modified
src/app/Browser.qml (+1/-1)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/fix-webview-height-landscape
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
David Barth (community) Approve
Review via email: mp+189610@code.launchpad.net

Commit message

Fix the height of the webview container when in landscape orientation.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
David Barth (dbarth) wrote :

looks *awesome* to me :)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/app/Browser.qml'
--- src/app/Browser.qml 2013-10-04 09:44:35 +0000
+++ src/app/Browser.qml 2013-10-07 14:03:23 +0000
@@ -126,7 +126,7 @@
126 right: parent.right126 right: parent.right
127 top: parent.top127 top: parent.top
128 }128 }
129 height: browser.height - osk.height129 height: parent.height - osk.height
130 }130 }
131131
132 ErrorSheet {132 ErrorSheet {

Subscribers

People subscribed via source and target branches

to status/vote changes: