Merge lp:~osomon/webbrowser-app/drawer-menu-actions-visible into lp:webbrowser-app
Proposed by
Olivier Tilloy
Status: | Merged |
---|---|
Approved by: | Ugo Riboni |
Approved revision: | 1177 |
Merged at revision: | 1182 |
Proposed branch: | lp:~osomon/webbrowser-app/drawer-menu-actions-visible |
Merge into: | lp:webbrowser-app |
Diff against target: |
45 lines (+5/-5) 1 file modified
src/app/webbrowser/Browser.qml (+5/-5) |
To merge this branch: | bzr merge lp:~osomon/webbrowser-app/drawer-menu-actions-visible |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Approve | |
Ubuntu Phablet Team | Pending | ||
Review via email: mp+270914@code.launchpad.net |
Commit message
Set the 'visible' property of actions instead of 'enabled' to ensure the visibility of the corresponding entries in the drawer menu matches.
To post a comment you must log in.
PASSED: Continuous integration, rev:1177 jenkins. qa.ubuntu. com/job/ webbrowser- app-ci/ 2227/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 4146 jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- amd64-ci/ 981 jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- armhf-ci/ 981 jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- armhf-ci/ 981/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- i386-ci/ 981 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 3382 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 4143 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 4143/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 23277
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/webbrowser- app-ci/ 2227/rebuild
http://