Merge lp:~openerp-dev/openobject-addons/trunk-base_contact-last_name-jth into lp:openobject-addons/6.1

[Julien Thewys]

Fixes minor usability and consistency concerns about the new "last_name" field in base_contact:
- the old "name" was used instead of "last_name"
- first_name should come first, last_name should come last (except in a few cultures).

[lp:~openerp-dev/openobject-addons/trunk-base_contact-last_name-jth]

6567. By Julien Thewys on 2012-02-24

[FIX] base_contact: stripping contact full name is more consistent

Unmerged revisions

6567. By Julien Thewys on 2012-02-24

[FIX] base_contact: stripping contact full name is more consistent

6566. By Julien Thewys on 2012-02-13

[FIX] base_contact: use new last_name field correctly

=== modified file 'base_contact/base_contact.py'
--- base_contact/base_contact.py	2012-02-15 13:22:13 +0000
+++ base_contact/base_contact.py	2012-02-24 12:29:24 +0000
@@ -29,9 +29,9 @@
     _description = "Contact"
 
     def _name_get_full(self, cr, uid, ids, prop, unknow_none, context=None):
-        result = {}
+        result = dict.fromkeys(ids, "NONAME")
         for rec in self.browse(cr, uid, ids, context=context):
-            result[rec.id] = rec.last_name+' '+(rec.first_name or '')
+            result[rec.id] = ('%s %s' % ((rec.first_name or ''), rec.last_name)).strip()
         return result
 
     _columns = {
@@ -73,7 +73,7 @@
         if context is None:
             context = {}
         if name:
-            ids = self.search(cr, uid, ['|',('name', operator, name),('first_name', operator, name)] + args, limit=limit, context=context)
+            ids = self.search(cr, uid, ['|',('last_name', operator, name),('first_name', operator, name)] + args, limit=limit, context=context)
         else:
             ids = self.search(cr, uid, args, limit=limit, context=context)
         return self.name_get(cr, uid, ids, context=context)
 
=== modified file 'base_contact/base_contact_view.xml'
--- base_contact/base_contact_view.xml	2012-01-31 13:36:57 +0000
+++ base_contact/base_contact_view.xml	2012-02-24 12:29:24 +0000
@@ -10,8 +10,8 @@
         <field name="type">tree</field>
         <field name="arch" type="xml">
             <tree string="Partner Contact">
-                <field name="name"/>
                 <field name="first_name"/>
+                <field name="last_name"/>
                 <field name="mobile"/>
                 <field name="email"/>
                 <field name="lang_id"/>