Merge lp:~openerp-dev/openobject-addons/6.1-opw-577036-skh into lp:openobject-addons/6.1

Proposed by Somesh Khare
Status: Approved
Approved by: Naresh(OpenERP)
Approved revision: 6944
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-577036-skh
Merge into: lp:openobject-addons/6.1
Diff against target: 12 lines (+1/-1)
1 file modified
hr_timesheet_invoice/wizard/hr_timesheet_invoice_create.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-577036-skh
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Approve
Review via email: mp+119305@code.launchpad.net

Description of the change

Hello Sir,

[Fix]: When you invoice your time-sheet lines, the generated invoice line contains the analytic account, due to which the amount does double into the Analytic entries analysis report.

Steps:
1. I make a project from "Sales/Sales/Contracts".
2. Connect project to customer and set "Invoice on Timesheet & Costs" 100%.
3. Go-to HR – Timesheet lines and Create a timesheet line of 20 hours on this project
4. Go-to "Sales/Invoicing/All Uninvoiced Entries" select the line and Crate Invoice from the wizard.
6. I confirm and validate this invoice
7. Go-to "Accounting/Reporting/Statistic Reports/Analytic Entries Analysis" the quantity = 40 and NOT 20 and the amount is not 20x30=600, but it is 900.

This is due to the analytic account set on the invoice. I have set the analytic account as False at the time invoice line creation. Please review the branch and share your views.

Thanks & Regards,
Somesh Khare

To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) :
review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello,

This bug was qualified as Confirmed on Trunk (means still existing and reproducible). A Merge Proposal for trunk was created to fix it. Here is the link to follow the MP on Launchpad https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-opw-577036-port-mma/+merge/135098 and be informed once it's been merged in trunk: ... If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Thanks,
Naresh Soni

Unmerged revisions

6944. By Somesh Khare

[FIX]hr_timesheet_invoice_create: Analylitic entries analysis report shows the double amounts is due to the fact that when invoice timesheet lines the generated invoice line contains the analytic account (Case: ref 577036)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'hr_timesheet_invoice/wizard/hr_timesheet_invoice_create.py'
--- hr_timesheet_invoice/wizard/hr_timesheet_invoice_create.py 2011-11-16 14:59:58 +0000
+++ hr_timesheet_invoice/wizard/hr_timesheet_invoice_create.py 2012-08-13 06:59:19 +0000
@@ -141,7 +141,7 @@
141 'invoice_line_tax_id': [(6,0,tax)],141 'invoice_line_tax_id': [(6,0,tax)],
142 'uos_id': uom,142 'uos_id': uom,
143 'account_id': account_id,143 'account_id': account_id,
144 'account_analytic_id': account.id,144 'account_analytic_id': False,
145 }145 }
146146
147 #147 #