Merge lp:~openerp-dev/openobject-addons/6.1-opw-574178-pso into lp:openobject-addons/6.1

[Priyesh (OpenERP)]

Hello,

Issue is only coming in web-client.

To produce the issue:
Install account_bank_statement_extensions module.
Open Bank Statement Lines.
Create a new one and try to set Account and Analytic Account.
It will raise an error.

I fixed this issue and improved usability in Bank statement line.

Thanks,
Priyesh Solanki

[Vinay Rana (OpenERP) (vra-openerp)]

This issue is reproduce with some manual steps:
>open the Bank statement line
>Create a new line
>now directly try to select General Account or Analytic account will raises the error.

The propose fixes will fix the issue as per my test case.

Nice fix ...

review: Approve

[Naresh(OpenERP) (nch-openerp)]

Hello,

This bug was qualified as Confirmed on Trunk (means still existing and reproducible). A Merge Proposal for trunk was created to fix it. Here is the link to follow the MP on Launchpad https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-opw-574178-port-mma/+merge/132259 and be informed once it's been merged in trunk: ... If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Thanks,
Naresh Soni

Unmerged revisions

6780. By Priyesh (OpenERP) on 2012-05-01

[FIX] account_bank_statement_extensions: Removed use of parent in bank statement line and improved usability(case:574178)

=== modified file 'account_bank_statement_extensions/account_bank_statement_view.xml'
--- account_bank_statement_extensions/account_bank_statement_view.xml	2012-01-31 13:36:57 +0000
+++ account_bank_statement_extensions/account_bank_statement_view.xml	2012-05-01 07:28:18 +0000
@@ -73,12 +73,12 @@
           <field name="date" readonly="1" groups="base.group_extended"/>
           <field name="val_date" readonly="1"/>
           <field name="name"/>
-          <field name="statement_id" readonly="1"/>
+          <field name="statement_id"/>
           <field name="ref" readonly="1"/>
           <field name="partner_id" on_change="onchange_partner_id(partner_id)"/>
           <field name="type" on_change="onchange_type(partner_id, type)"/>
-          <field name="account_id" domain="[('journal_id','=',parent.journal_id)]"/>
-          <field name="analytic_account_id" groups="analytic.group_analytic_accounting" domain="[('company_id', '=', parent.company_id), ('type', '&lt;&gt;', 'view')]"/>
+          <field name="account_id"/>
+          <field name="analytic_account_id" groups="analytic.group_analytic_accounting" domain="[('type', '&lt;&gt;', 'view')]"/>
           <field name="amount" readonly="1" sum="Total Amount"/>
           <field name="globalisation_id" string="Glob. Id"/>
           <field name="globalisation_amount" string="Glob. Am."/>
@@ -101,8 +101,8 @@
           <field name="ref" readonly="0"/>
           <field name="partner_id" on_change="onchange_partner_id(partner_id)"/>
           <field name="type" on_change="onchange_type(partner_id, type)"/>
-          <field domain="[('journal_id', '=', parent.journal_id), ('type', '&lt;&gt;', 'view')]" name="account_id"/>
-          <field name="analytic_account_id" groups="analytic.group_analytic_accounting" domain="[('company_id', '=', parent.company_id), ('type', '&lt;&gt;', 'view')]"/>
+          <field domain="[('type', '&lt;&gt;', 'view')]" name="account_id"/>
+          <field name="analytic_account_id" groups="analytic.group_analytic_accounting" domain="[('type', '&lt;&gt;', 'view')]"/>
           <field name="amount"/>
           <field name="globalisation_id"/>
           <field name="sequence" readonly="0"/>