Merge lp:~openerp-dev/openerp-web/7.0-opw-601145-msh into lp:openerp-web/7.0

Proposed by Mohammed Shekha(Open ERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openerp-web/7.0-opw-601145-msh
Merge into: lp:openerp-web/7.0
Diff against target: 35 lines (+7/-3)
2 files modified
addons/web/static/src/css/base.css (+4/-2)
addons/web/static/src/css/base.sass (+3/-1)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-opw-601145-msh
Reviewer Review Type Date Requested Status
Xavier (Open ERP) Pending
Martin Trigaux (OpenERP) Pending
Review via email: mp+199389@code.launchpad.net

Description of the change

Hello,

Fixed the issue of IE10, hide text in alternative way, as it works in all browser and with all versions.

Demo:- Use IE10 and go to List view and just select any record, you will see sidebar does not shows button's text(Add, More etc.)

IE10 has issue with text-indent + with negative value so used alternate way as it is supported in all browser.

Thanks.

To post a comment you must log in.

Unmerged revisions

4087. By Mohammed Shekha(OpenERP)<email address hidden>

[FIX]Web: Fixed the issue of IE10, hide text in alternative way, as it works in all browser and with all versions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'addons/web/static/src/css/base.css'
--- addons/web/static/src/css/base.css 2013-12-10 11:24:44 +0000
+++ addons/web/static/src/css/base.css 2013-12-18 05:50:45 +0000
@@ -1,4 +1,4 @@
1@charset "utf-8";1@charset "UTF-8";
2@font-face {2@font-face {
3 font-family: "mnmliconsRegular";3 font-family: "mnmliconsRegular";
4 src: url("/web/static/src/font/mnmliconsv21-webfont.eot") format("eot");4 src: url("/web/static/src/font/mnmliconsv21-webfont.eot") format("eot");
@@ -731,7 +731,9 @@
731 height: 0;731 height: 0;
732 display: inline-block;732 display: inline-block;
733 content: "&darr";733 content: "&darr";
734 text-indent: -99999px;734 text-indent: 100%;
735 overflow: hidden;
736 white-space: nowrap;
735 vertical-align: top;737 vertical-align: top;
736 margin-top: 8px;738 margin-top: 8px;
737 margin-left: 3px;739 margin-left: 3px;
738740
=== modified file 'addons/web/static/src/css/base.sass'
--- addons/web/static/src/css/base.sass 2013-12-10 11:24:44 +0000
+++ addons/web/static/src/css/base.sass 2013-12-18 05:50:45 +0000
@@ -621,7 +621,9 @@
621 height: 0621 height: 0
622 display: inline-block622 display: inline-block
623 content: "&darr"623 content: "&darr"
624 text-indent: -99999px624 text-indent: 100%
625 overflow: hidden
626 white-space: nowrap
625 vertical-align: top627 vertical-align: top
626 margin-top: 8px628 margin-top: 8px
627 //margin-left set at 3px to avoid a strange overflow629 //margin-left set at 3px to avoid a strange overflow