Merge lp:~openerp-dev/openerp-web/7.0-opw-586295-msh into lp:openerp-web/7.0
Status: | Needs review |
---|---|
Proposed branch: | lp:~openerp-dev/openerp-web/7.0-opw-586295-msh |
Merge into: | lp:openerp-web/7.0 |
Diff against target: |
15 lines (+5/-1) 1 file modified
addons/web/static/src/js/view_list.js (+5/-1) |
To merge this branch: | bzr merge lp:~openerp-dev/openerp-web/7.0-opw-586295-msh |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Xavier (Open ERP) (community) | Needs Fixing | ||
Mohammed Shekha(Open ERP) (community) | Needs Resubmitting | ||
Martin Trigaux (OpenERP) | Pending | ||
Review via email: mp+153347@code.launchpad.net |
Description of the change
Hello,
Fixed the issue of create button which should be disabled when there is grouped data in list view.
Demo:- Open any list view and select group by filter, see still create button is enabled whereas it should be disabled, there is already code written to prop button but not at proper place.
Initially fields_view_get is called so on done of fields_view_get load_list is called at that time grouping will not be there so initially create button will be enabled now grouping is applied so again fields_view_get is called but now buttons are available in this.$buttons so it not going to disable the create button.
Thanks.
Unmerged revisions
- 3841. By Mohammed Shekha<email address hidden>
-
[FIX]Fixed the issue of create button which should be disabled when there is grouped data in list view.
Why test `if (this.$buttons)` since lines above always assign this.$buttons if does not already exist?