Merge ~ondrak/ubuntu/+source/linux/+git/xenial:wcn36xx-fix into ~ubuntu-kernel/ubuntu/+source/linux/+git/xenial:snapdragon
Status: | Needs review |
---|---|
Proposed branch: | ~ondrak/ubuntu/+source/linux/+git/xenial:wcn36xx-fix |
Merge into: | ~ubuntu-kernel/ubuntu/+source/linux/+git/xenial:snapdragon |
Diff against target: |
87 lines (+13/-5) 3 files modified
drivers/net/wireless/ath/wcn36xx/main.c (+7/-3) drivers/net/wireless/ath/wcn36xx/smd.c (+4/-2) drivers/net/wireless/ath/wcn36xx/smd.h (+2/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paolo Pisati (community) | Disapprove | ||
Review via email: mp+346751@code.launchpad.net |
Commit message
UBUNTU: wcn36xx: pass correct BSS index when deleting BSS keys
BugLink: https:/
BugLink: https:/
Patch link: https:/
The firmware message to delete BSS keys expects a BSS index to be passed.
This field is currently hard-coded to 0. Fix this by passing in the index
we received from the firmware when the BSS was configured.
The encryption type in that message also needs to be set to what was used
when the key was set, so the assignment of vif_priv-
done after the firmware command was sent. This reportedly fixes the
following error in AP mode:
wcn36xx: ERROR hal_remove_bsskey response failed err=6
Also, AFAIU, when a BSS is deleted, the firmware apparently drops all the
keys associated with it. Trying to remove the key explicitly afterwards
will hence lead to the following message:
wcn36xx: ERROR hal_remove_bsskey response failed err=16
This is now suppressed with an extra check for the BSS index validity.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
I don't have write access to the kernel repository, only the stable team has it: resend it to the ubuntu kernel ml for review.