Merge lp:~om26er/ubuntu/natty/libdbusmenu/dbusmenu-fix-618587 into lp:ubuntu/natty/libdbusmenu

Proposed by Omer Akram
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp:~om26er/ubuntu/natty/libdbusmenu/dbusmenu-fix-618587
Merge into: lp:ubuntu/natty/libdbusmenu
Diff against target: 50 lines (+25/-0)
2 files modified
debian/changelog (+7/-0)
libdbusmenu-gtk/parser.c (+18/-0)
To merge this branch: bzr merge lp:~om26er/ubuntu/natty/libdbusmenu/dbusmenu-fix-618587
Reviewer Review Type Date Requested Status
Ubuntu Sponsors Pending
Review via email: mp+71892@code.launchpad.net

Description of the change

backport the fix for lp: 618587 for Natty.

To post a comment you must log in.

Unmerged revisions

85. By Omer Akram

* libdbusmenu-gtk/parser.c:
  - Eclipse does not work with appmenu. (LP: #618587)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-04-19 15:14:23 +0000
+++ debian/changelog 2011-08-17 13:41:23 +0000
@@ -1,3 +1,10 @@
1libdbusmenu (0.4.3-0ubuntu4) natty; urgency=low
2
3 * libdbusmenu-gtk/parser.c:
4 - Eclipse does not work with appmenu. (LP: #618587)
5
6 -- Omer Akram <om26er@ubuntu.com> Wed, 17 Aug 2011 18:27:45 +0500
7
1libdbusmenu (0.4.3-0ubuntu3) natty; urgency=low8libdbusmenu (0.4.3-0ubuntu3) natty; urgency=low
29
3 * Backport bug fixes from trunk:10 * Backport bug fixes from trunk:
411
=== modified file 'libdbusmenu-gtk/parser.c'
--- libdbusmenu-gtk/parser.c 2011-04-15 15:55:37 +0000
+++ libdbusmenu-gtk/parser.c 2011-08-17 13:41:23 +0000
@@ -270,6 +270,16 @@
270 return item;270 return item;
271}271}
272272
273static gboolean
274toggle_widget_visibility (GtkWidget * widget)
275{
276 gboolean vis = gtk_widget_get_visible (widget);
277 gtk_widget_set_visible (widget, !vis);
278 gtk_widget_set_visible (widget, vis);
279 g_object_unref (G_OBJECT (widget));
280 return FALSE;
281}
282
273static void283static void
274watch_submenu(DbusmenuMenuitem * mi, GtkWidget * menu)284watch_submenu(DbusmenuMenuitem * mi, GtkWidget * menu)
275{285{
@@ -285,6 +295,14 @@
285 G_CALLBACK (child_removed_cb),295 G_CALLBACK (child_removed_cb),
286 mi);296 mi);
287 g_object_add_weak_pointer(G_OBJECT (menu), (gpointer*)&pdata->shell);297 g_object_add_weak_pointer(G_OBJECT (menu), (gpointer*)&pdata->shell);
298
299 /* Some apps (notably Eclipse RCP apps) don't fill contents of submenus
300 until the menu is shown. So we fake that by toggling the visibility of
301 any submenus we come across. Further, these apps need it done with a
302 delay while they finish initializing, so we put the call in the idle
303 queue. */
304 g_idle_add((GSourceFunc)toggle_widget_visibility,
305 g_object_ref (G_OBJECT (menu)));
288}306}
289307
290static void308static void

Subscribers

People subscribed via source and target branches

to all changes: