Merge lp:~om26er/ubuntu-weather-app/fix_autopilot_tests_touch into lp:ubuntu-weather-app/obsolete.trunk
Proposed by
Omer Akram
Status: | Merged |
---|---|
Approved by: | Martin Borho |
Approved revision: | 87 |
Merged at revision: | 83 |
Proposed branch: | lp:~om26er/ubuntu-weather-app/fix_autopilot_tests_touch |
Merge into: | lp:ubuntu-weather-app/obsolete.trunk |
Diff against target: |
158 lines (+49/-19) 3 files modified
components/AddLocationSheet.qml (+1/-0) components/LocationManagerSheet.qml (+2/-0) tests/autopilot/ubuntu_weather_app/tests/test_locationmanager.py (+46/-19) |
To merge this branch: | bzr merge lp:~om26er/ubuntu-weather-app/fix_autopilot_tests_touch |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Martin Borho | Approve | ||
Review via email: mp+178397@code.launchpad.net |
Commit message
Fix failing autopilot tests on touch
Description of the change
Fix failing autopilot tests on touch
To post a comment you must log in.
Hi Omer,
there's no "index" for "currentLocatio nItem" + index, you should just call it "currentLocatio nItem". (LocationManage rSheet, L108)
Otherwise it's just fine, thanks a lot!
Now the only thing left is that "ubuntu_ weather_ app.tests. test_locationma nager.TestLocat ionManager. test_search_ city" won't work on the device, since the "BackSpace" key is unknown. I've found a (litlle bit reckless) solution for that: Line 95 in http:// bazaar. launchpad. net/~martin- borho/ubuntu- weather- app/device_ tests_and_ emulator/ revision/ 83/tests/ autopilot/ ubuntu_ weather_ app/tests/ test_locationma nager.py#
Perhaps you can incorporate that in a less hackish way, if you know one? Otherwise I could do that later on, no problem!
Thanks anyways!
Martin