Merge ~oddbloke/cloud-init/+git/cloud-init:nested_set into cloud-init:master

Proposed by Dan Watkins
Status: Merged
Approved by: Dan Watkins
Approved revision: d6a8772f3f20b58e2b5ab1b9669083b5952e8583
Merge reported by: Server Team CI bot
Merged at revision: not available
Proposed branch: ~oddbloke/cloud-init/+git/cloud-init:nested_set
Merge into: cloud-init:master
Diff against target: 11 lines (+1/-1)
1 file modified
cloudinit/config/cc_rsyslog.py (+1/-1)
Reviewer Review Type Date Requested Status
Ryan Harper Approve
Server Team CI bot continuous-integration Approve
Review via email: mp+363483@code.launchpad.net

Commit message

cc_rsyslog: Escape possible nested set

Under Python 3.7, we are seeing `FutureWarning: Possible nested set at
position 23`; escaping this bracket causes that warning to disappear.

LP: #1816967

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:d6a8772f3f20b58e2b5ab1b9669083b5952e8583
https://jenkins.ubuntu.com/server/job/cloud-init-ci/574/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    FAILED: Ubuntu LTS: Integration

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/574/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:d6a8772f3f20b58e2b5ab1b9669083b5952e8583
https://jenkins.ubuntu.com/server/job/cloud-init-ci/575/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    FAILED: Ubuntu LTS: Integration

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/575/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:d6a8772f3f20b58e2b5ab1b9669083b5952e8583
https://jenkins.ubuntu.com/server/job/cloud-init-ci/576/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    SUCCESS: Ubuntu LTS: Integration
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/576/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ryan Harper (raharper) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/cloudinit/config/cc_rsyslog.py b/cloudinit/config/cc_rsyslog.py
index 27d2366..22b1753 100644
--- a/cloudinit/config/cc_rsyslog.py
+++ b/cloudinit/config/cc_rsyslog.py
@@ -203,7 +203,7 @@ LOG = logging.getLogger(__name__)
203COMMENT_RE = re.compile(r'[ ]*[#]+[ ]*')203COMMENT_RE = re.compile(r'[ ]*[#]+[ ]*')
204HOST_PORT_RE = re.compile(204HOST_PORT_RE = re.compile(
205 r'^(?P<proto>[@]{0,2})'205 r'^(?P<proto>[@]{0,2})'
206 r'(([[](?P<bracket_addr>[^\]]*)[\]])|(?P<addr>[^:]*))'206 r'(([\[](?P<bracket_addr>[^\]]*)[\]])|(?P<addr>[^:]*))'
207 r'([:](?P<port>[0-9]+))?$')207 r'([:](?P<port>[0-9]+))?$')
208208
209209

Subscribers

People subscribed via source and target branches