Merge lp:~octoquad/software-center/899878-hardcoded-colors-dark-theme into lp:software-center

Proposed by Bruce Pieterse
Status: Merged
Merged at revision: 3338
Proposed branch: lp:~octoquad/software-center/899878-hardcoded-colors-dark-theme
Merge into: lp:software-center
Prerequisite: lp:~octoquad/software-center/1448355-docs-fix-aptdaemon-test
Diff against target: 179 lines (+130/-5)
4 files modified
data/ui/gtk3/css/softwarecenter.adwaita-dark.css (+120/-0)
data/ui/gtk3/css/softwarecenter.css (+2/-2)
softwarecenter/ui/gtk3/utils.py (+7/-2)
softwarecenter/ui/gtk3/views/catview.py (+1/-1)
To merge this branch: bzr merge lp:~octoquad/software-center/899878-hardcoded-colors-dark-theme
Reviewer Review Type Date Requested Status
dobey Approve
Didier Roche-Tolomelli Approve
Review via email: mp+268849@code.launchpad.net

Description of the change

Added support for Adwaita Dark Theme Variant

- Added new softwarecenter.adwaita-dark.css file
- Added detection for adwaita and dark theme setting
- Adjusted transparency drawing of stipple by 20%

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Looking good to me, I tried with adwaita and ambiance/radiance.

The stipple changes don't seem to have a huge impact UI change on white themes, so all is good :)
Thanks again! Merging and patching our wily packages with it.

review: Approve
Revision history for this message
dobey (dobey) wrote :

Please sign the contributor agreement at http://www.ubuntu.com/legal/contributors as it is required for Software Center. Thanks

review: Needs Fixing
Revision history for this message
Bruce Pieterse (octoquad) wrote :

Signed.

Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file 'data/ui/gtk3/css/softwarecenter.adwaita-dark.css'
--- data/ui/gtk3/css/softwarecenter.adwaita-dark.css 1970-01-01 00:00:00 +0000
+++ data/ui/gtk3/css/softwarecenter.adwaita-dark.css 2015-08-23 11:56:20 +0000
@@ -0,0 +1,120 @@
1/* UI Colors
2
3 Palette: https://developer.gnome.org/hig-book/unstable/design-color.html.en
4*/
5
6@define-color accent-red-dark #990000;
7@define-color basic-threed-hilight #EAE8E3;
8@define-color basic-threed-medium #BAB5AB;
9@define-color blue-hilight #4B6983;
10@define-color blue-medium #7590AE;
11@define-color blue-shadow #314E6C;
12@define-color threed-shadow #565248;
13@define-color basic-threed-dark #807D74;
14
15/* - Custom */
16@define-color custom-nls-pane #292929;
17@define-color custom-nls-focus-blue #154D90;
18@define-color custom-light-blue #8DB3DF;
19@define-color custom-light-gray #C4C4C4;
20
21/* - Debugging Color */
22@define-color debug #990000;
23
24/*
25 do not use text-shadow until bugzilla.gnome.org bug #686209 is
26 fixed - its leaking memory. Has Status: RESOLVED FIXED as of 2015-05-27. Safe to use?
27*/
28
29/* GTK */
30GtkViewport {
31 background-color: @custom-nls-pane;
32 border-width: 0;
33 padding: 0;
34}
35
36/* - More, Category Listing */
37GtkTreeView {
38 background-color: @custom-nls-pane;
39}
40GtkTreeView:selected {
41 background-color: @custom-nls-focus-blue;
42}
43
44/* All Software, Installed Drop-Downs */
45#toolbar-popup {
46 padding: 0;
47}
48
49
50/* Landing */
51
52/* - What's New, Top Rated Table Header
53 - - More Button
54*/
55.more-link {
56 -GtkButton-inner-border: 0;
57 -GtkButton-default-border: 0;
58 -GtkButton-default-outside-border: 0;
59 color: @custom-light-gray;
60 background-color: shade (@custom-nls-pane, 0.925);
61 border-color: shade (@custom-nls-pane, 0.875);
62 padding: 10px;
63}
64
65.more-link:hover {
66 color: @blue-hilight;
67}
68
69/* - - Table Header*/
70.frame-header-title {
71 color: @basic-threed-hilight;
72 padding: 10px;
73}
74
75/* - - Table Cells */
76.grid-lines {
77 border-color: @threed-shadow;
78}
79
80/* - Price, Hints
81 - - App Info: Version, Total Size, License, Updates
82*/
83.subtle,
84#subtle-label {
85 -GtkWidget-link-color: shade (@basic-threed-hilight 1);
86 -GtkWidget-visited-link-color: shade (@basic-threed-hilight, 1);
87 color: shade (@basic-threed-hilight, 1); /* non-link text color */
88}
89
90/* - Package Information */
91#screenshot-preview {
92 border-color: @blue-shadow;
93 color: @blue-hilight;
94 border-width: 2px;
95 border-radius: 3px;
96}
97
98/* - - Horizontal Rule */
99.item-view-separator {
100 border-color: shade (@threed-shadow, 0.9);
101 border-width: 1px;
102}
103
104/* Category Listing */
105/* - Row Information: Review Counter: Package Name ***** (12) */
106.cellrenderer-avgrating-label {
107 color: @threed-shadow;
108 background-color: @custom-light-gray;
109}
110.cellrenderer-avgrating-label:selected {
111 color: @basic-threed-hilight;
112 background-color: @custom-light-blue;
113}
114
115/* Global */
116/* - Ratings Star */
117#featured-star {
118 border-color: @basic-threed-medium;
119 color: @basic-threed-hilight;
120}
0121
=== modified file 'data/ui/gtk3/css/softwarecenter.css'
--- data/ui/gtk3/css/softwarecenter.css 2012-10-16 09:21:14 +0000
+++ data/ui/gtk3/css/softwarecenter.css 2015-08-23 11:56:20 +0000
@@ -1,8 +1,8 @@
1@define-color light-aubergine #DED7DB;1@define-color light-aubergine #DED7DB;
2@define-color super-light-aubergine #F4F1F3;2@define-color super-light-aubergine #F4F1F3;
33
4/* 4/*
5 do not use text-shadow until bugzilla.gnome.org bug #686209 is 5 do not use text-shadow until bugzilla.gnome.org bug #686209 is
6 fixed - its leaking memory6 fixed - its leaking memory
7*/7*/
88
99
=== modified file 'softwarecenter/ui/gtk3/utils.py'
--- softwarecenter/ui/gtk3/utils.py 2012-11-23 22:57:21 +0000
+++ softwarecenter/ui/gtk3/utils.py 2015-08-23 11:56:20 +0000
@@ -52,6 +52,7 @@
52 datadir = softwarecenter.paths.datadir52 datadir = softwarecenter.paths.datadir
53 context = toplevel.get_style_context()53 context = toplevel.get_style_context()
54 theme_name = settings.get_property("gtk-theme-name").lower()54 theme_name = settings.get_property("gtk-theme-name").lower()
55 adwaita_dark_theme = settings.get_property("gtk-application-prefer-dark-theme")
5556
56 if hasattr(toplevel, '_css_provider'):57 if hasattr(toplevel, '_css_provider'):
57 # check old provider, see if we can skip setting or remove old58 # check old provider, see if we can skip setting or remove old
@@ -62,8 +63,12 @@
62 context.remove_provider_for_screen(screen, toplevel._css_provider)63 context.remove_provider_for_screen(screen, toplevel._css_provider)
6364
64 # munge css path for theme-name65 # munge css path for theme-name
65 css_path = os.path.join(66 if theme_name == 'adwaita' and adwaita_dark_theme:
66 datadir, "ui/gtk3/css/softwarecenter.%s.css" % theme_name)67 css_path = os.path.join(
68 datadir, "ui/gtk3/css/softwarecenter.%s-dark.css" % theme_name)
69 else:
70 css_path = os.path.join(
71 datadir, "ui/gtk3/css/softwarecenter.%s.css" % theme_name)
6772
68 # if no css for theme-name try fallback css73 # if no css for theme-name try fallback css
69 if not os.path.exists(css_path):74 if not os.path.exists(css_path):
7075
=== modified file 'softwarecenter/ui/gtk3/views/catview.py'
--- softwarecenter/ui/gtk3/views/catview.py 2012-12-14 16:44:25 +0000
+++ softwarecenter/ui/gtk3/views/catview.py 2015-08-23 11:56:20 +0000
@@ -175,7 +175,7 @@
175 def do_draw(self, cr):175 def do_draw(self, cr):
176 cr.save()176 cr.save()
177 cr.set_source(_asset_cache["stipple"])177 cr.set_source(_asset_cache["stipple"])
178 cr.paint_with_alpha(0.5)178 cr.paint_with_alpha(0.3)
179 cr.restore()179 cr.restore()
180 for child in self:180 for child in self:
181 self.propagate_draw(child, cr)181 self.propagate_draw(child, cr)