Merge lp:~ochosi/ubuntu/vivid/xdg-utils/drop_xserver_patch into lp:ubuntu/vivid/xdg-utils

Proposed by Simon Steinbeiß
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 26
Merged at revision: 26
Proposed branch: lp:~ochosi/ubuntu/vivid/xdg-utils/drop_xserver_patch
Merge into: lp:ubuntu/vivid/xdg-utils
Diff against target: 137 lines (+0/-112)
3 files modified
debian/patches/series (+0/-1)
debian/patches/xserver-blanking.diff (+0/-68)
scripts/xdg-screensaver (+0/-43)
To merge this branch: bzr merge lp:~ochosi/ubuntu/vivid/xdg-utils/drop_xserver_patch
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+246101@code.launchpad.net

Description of the change

The xdg-screensaver script is currently carrying a patch that has already been merged which results in duplicate code.
This merge-request drops the duplicate portions of the script and the now superfluous patch.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/patches/series'
--- debian/patches/series 2014-07-16 09:20:59 +0000
+++ debian/patches/series 2015-01-12 09:56:18 +0000
@@ -1,6 +1,5 @@
1xdg-mime-follow-symlinks.diff1xdg-mime-follow-symlinks.diff
2x-www-browser.diff2x-www-browser.diff
3xserver-blanking.diff
4xdg-email-envvar.diff3xdg-email-envvar.diff
5xdg-email-mutt-detect.diff4xdg-email-mutt-detect.diff
6xdg-mime-generic-use-mimetype.diff5xdg-mime-generic-use-mimetype.diff
76
=== removed file 'debian/patches/xserver-blanking.diff'
--- debian/patches/xserver-blanking.diff 2011-02-20 18:34:53 +0000
+++ debian/patches/xserver-blanking.diff 1970-01-01 00:00:00 +0000
@@ -1,68 +0,0 @@
1Description: Support X server blanking in xdg-screensaver.
2Bug: https://bugs.freedesktop.org/show_bug.cgi?id=30561
3Bug-Debian: http://bugs.debian.org/511248
4Author: Ben Hutchings <ben@decadent.org.uk>
5
6--- a/scripts/xdg-screensaver
7+++ b/scripts/xdg-screensaver
8@@ -435,6 +435,10 @@ perform_action()
9 '')
10 screensaver_xserver "$1"
11 ;;
12+
13+ '')
14+ screensaver_xserver "$1"
15+ ;;
16 esac
17
18 if [ "$1" = "suspend" ] ; then
19@@ -682,6 +686,49 @@ screensaver_kde()
20 return 1
21 fi
22 ;;
23+
24+ *)
25+ echo "ERROR: Unknown command '$1'" >&2
26+ return 1
27+ ;;
28+ esac
29+}
30+
31+screensaver_xserver()
32+{
33+ case "$1" in
34+ suspend)
35+ xset s off > /dev/null
36+ result=$?
37+ ;;
38+
39+ resume)
40+ xset s default > /dev/null
41+ result=$?
42+ ;;
43+
44+ activate)
45+ xset s activate > /dev/null
46+ result=$?
47+ ;;
48+
49+ reset)
50+ xset s reset > /dev/null
51+ result=$?
52+ ;;
53+
54+ status)
55+ timeout=`xset q | sed '/^Screen Saver:/,/^[^ ]/ { s/.*timeout: *\([0-9]*\).*/\1/; t }; d'`
56+ result=$?
57+ if [ "$timeout" -gt 0 ]; then
58+ echo "enabled"
59+ elif [ "$timeout" -eq 0 ]; then
60+ echo "disabled"
61+ else
62+ echo "ERROR: xset q did not report the screensaver timeout" >&2
63+ return 1
64+ fi
65+ ;;
66
67 *)
68 echo "ERROR: Unknown command '$1'" >&2
690
=== modified file 'scripts/xdg-screensaver'
--- scripts/xdg-screensaver 2014-07-16 09:20:59 +0000
+++ scripts/xdg-screensaver 2015-01-12 09:56:18 +0000
@@ -737,49 +737,6 @@
737 esac737 esac
738}738}
739739
740screensaver_xserver()
741{
742 case "$1" in
743 suspend)
744 xset s off > /dev/null
745 result=$?
746 ;;
747
748 resume)
749 xset s default > /dev/null
750 result=$?
751 ;;
752
753 activate)
754 xset s activate > /dev/null
755 result=$?
756 ;;
757
758 reset)
759 xset s reset > /dev/null
760 result=$?
761 ;;
762
763 status)
764 timeout=`xset q | sed '/^Screen Saver:/,/^[^ ]/ { s/.*timeout: *\([0-9]*\).*/\1/; t }; d'`
765 result=$?
766 if [ "$timeout" -gt 0 ]; then
767 echo "enabled"
768 elif [ "$timeout" -eq 0 ]; then
769 echo "disabled"
770 else
771 echo "ERROR: xset q did not report the screensaver timeout" >&2
772 return 1
773 fi
774 ;;
775
776 *)
777 echo "ERROR: Unknown command '$1'" >&2
778 return 1
779 ;;
780 esac
781}
782
783screensaver_suspend_loop()740screensaver_suspend_loop()
784{741{
785 lockfile742 lockfile

Subscribers

People subscribed via source and target branches