Merge lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:~purchase-core-editors/purchase-wkfl/7.0

[Lionel Sausin - Initiatives/Numérigraphe]

This branch adds a new module which, when installed, creates one reception picking for each expected date on the purchase order.
This way stock workers have a clear view of which goods should be received when.

This modules uses the modular design of purchase orders to create several pickings rather that a single one: to the best f my knowledge, this should be compatible with the other modules in this branch.

[lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date]

31. By Numérigraphe on 2014-03-17

[ADD] authors file

[Loïc Bellier - Numérigraphe (lb-b)]

review: Approve (code review)

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Hi Lionel,

Thanks for the contrib ! A few remarks concerning community guideline:

 * L32 : use from . import purchase
 * L95 : use full path instead : from openerp.osv import orm
 * L114 : use let a print, remove it please

Otherwise, LGTM,

Regards,

Joël

review: Needs Fixing (code review, no tests)

[lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date]

32. By Numérigraphe on 2014-05-12

[REF] explicit import paths. Updated authors file. Use itervalues() when we don't need the keys

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

Thanks Joël, I've updated the module as you suggested.

[Lorenzo Battistini (elbati)]

review: Approve (code review)

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Please don't add AUTHOR.txt file and add Contributors in __openerp__.py

For who did exaclty what there is the CVS

review: Needs Fixing

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

Yannick, I agree, but I thought it was required for OCA modules - I can't remember why I assumed that, maybe read it in some guide somewhere.
I'll fix it.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Here is the reference for this community Guideline.

https://doc.openerp.com/contribute/05_developing_modules/#modules-description

This has the advantage to show who contributed directly on apps.odoo.com as we don't have such field in manifest.

[lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date]

33. By Numérigraphe on 2014-05-19

[DEL] remove AUTHORS file - annotate will tell whom to blame

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

I moved the crediting to a comment in __openerp__.py, is it right?

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Here is an exemple:

http://bazaar.launchpad.net/~report-print-send-core-editors/report-print-send/7.0/view/head:/base_report_to_printer/__openerp__.py

[lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date]

34. By Numérigraphe on 2014-05-19

[IMP] Make a 'contributor' paragraph

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

I think it's fixed now.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Perfect, thanks for the changes Lionel

review: Approve (code review, no test)

[Pedro Manuel Baeza (pedro.baeza)]

This project is now hosted on https://github.com/OCA/purchase-workflow. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Unmerged revisions

34. By Numérigraphe on 2014-05-19

[IMP] Make a 'contributor' paragraph

33. By Numérigraphe on 2014-05-19

[DEL] remove AUTHORS file - annotate will tell whom to blame

32. By Numérigraphe on 2014-05-12

[REF] explicit import paths. Updated authors file. Use itervalues() when we don't need the keys

31. By Numérigraphe on 2014-03-17

[ADD] authors file

30. By Numérigraphe on 2014-03-17

[ADD] Module to split purchase receptions into 1 picking by expected date

=== added directory 'purchase_delivery_split_date'
=== added file 'purchase_delivery_split_date/__init__.py'
--- purchase_delivery_split_date/__init__.py	1970-01-01 00:00:00 +0000
+++ purchase_delivery_split_date/__init__.py	2014-05-19 11:29:31 +0000
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved.
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from . import purchase
 
=== added file 'purchase_delivery_split_date/__openerp__.py'
--- purchase_delivery_split_date/__openerp__.py	1970-01-01 00:00:00 +0000
+++ purchase_delivery_split_date/__openerp__.py	2014-05-19 11:29:31 +0000
@@ -0,0 +1,41 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved.
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    'name': "Purchase Deliveries split by date",
+    'version': '1.0',
+    'author': u'Numérigraphe',
+    'category': 'Purchase Management',
+    'description': """
+Split Purchase Deliveries in one reception per expected date
+------------------------------------------------------------
+
+When this module is installed, each Purchase Order you confirm will generate one
+Reception Order per delivery date indicated in the Purchase Order Lines.
+
+Contributors
+------------
+
+ * Philippe Rossi <[e-mail]> (initial patch against v6.0)
+ * Lionel Sausin <[e-mail]> (modularization for v7.0)
+""",
+    'license': 'AGPL-3',
+    "depends": ['purchase'],
+}
 
=== added file 'purchase_delivery_split_date/purchase.py'
--- purchase_delivery_split_date/purchase.py	1970-01-01 00:00:00 +0000
+++ purchase_delivery_split_date/purchase.py	2014-05-19 11:29:31 +0000
@@ -0,0 +1,44 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved.
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import orm
+
+
+class PurchaseOrder(orm.Model):
+    _inherit = "purchase.order"
+
+    def _create_pickings(self, cr, uid, order, order_lines, picking_id=False,
+                         context=None):
+        """Group the Purchase Order's receptions by expected date"""
+        picking_ids = []
+        delivery_dates = {}
+        # Triage the order lines by delivery date
+        for line in order_lines:
+            if line.date_planned in delivery_dates:
+                delivery_dates[line.date_planned].append(line)
+            else:
+                delivery_dates[line.date_planned] = [line]
+        # Process each group of lines
+        for lines in delivery_dates.itervalues():
+            picking_ids.extend(
+                super(PurchaseOrder, self)._create_pickings(
+                    cr, uid, order, lines, picking_id=picking_id,
+                    context=context))
+        return picking_ids