Merge lp:~numerigraphe-team/ocb-addons/7.0-inventory-dummy-moves-test into lp:ocb-addons

[Lionel Sausin - Initiatives/Numérigraphe]

This branch adds a YAML test to detect possible regressions regarding bug #1228156.
It runs green on runbot: http://runbot.openerp.com/numerigraphe-team-7-0-ocb-runbot-inventory-dummy-moves-test-30874/logs/
Upstream MP: https://code.launchpad.net/~numerigraphe-team/openobject-addons/7.0-inventory-dummy-moves-test/+merge/214910

[Loïc Bellier - Numérigraphe (lb-b)]

review: Approve (code review)

[Stefan Rijnhart (Opener) (stefan-opener)]

Looks good in general, but I'm slightly puzzled the exception handling. Is it know when it raises and when it doesn't? Doesn't the occurrence of the exception render the test meaningless? And does that not make the whole excercise moot?

review: Needs Information

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

Stefan you're probably right, I'll look into this and let you know.

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

Fixed, still green in runbot.

[Holger Brunn (Therp) (hbrunn)]

Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid.

(I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad)

review: Disapprove

Unmerged revisions

10084. By Numérigraphe on 2014-05-16

[FIX] don't ignore exceptions in the test, that would render the test useless.

10083. By Numérigraphe on 2014-04-11

[MERGE] latest ocb branch

10082. By Numérigraphe on 2014-04-08

[MERGE] update test to demo dataset in v7

10081. By Numérigraphe on 2014-04-08

[MERGE] Add a test for bug 1228156: Wizard "Fill inventory" creates wrong lines for moves where source=destination

=== modified file 'stock/__openerp__.py'
--- stock/__openerp__.py	2014-04-04 18:52:40 +0000
+++ stock/__openerp__.py	2014-05-16 08:48:48 +0000
@@ -96,6 +96,7 @@
         'test/shipment.yml',
         'test/stock_report.yml',
         'test/stock_move_chain_validation.yml',
+        'test/stock_inventory_dummy_moves.yml',
     ],
     'installable': True,
     'application': True,
 
=== added file 'stock/test/stock_inventory_dummy_moves.yml'
--- stock/test/stock_inventory_dummy_moves.yml	1970-01-01 00:00:00 +0000
+++ stock/test/stock_inventory_dummy_moves.yml	2014-05-16 08:48:48 +0000
@@ -0,0 +1,47 @@
+-
+  This file test will verify the bug reported at https://bugs.launchpad.net/openobject-addons/+bug/1228156.
+  In order to test the bug fix, I will create stock move with same location for source and destination location,
+  create inventory, import inventory lines
+-
+  I create stock move with same source and destination location for product_pc2.
+-
+ !record {model: stock.move, id: same_location_move}:
+    name: 'Test move with same source and destination location'
+    location_id: stock_location_14
+    location_dest_id: stock_location_14
+    product_id: product.product_product_9
+    product_qty: 12.0
+    product_uom: product.product_uom_unit
+    state: 'done'
+-
+  I create inventory.
+-
+   !record {model: stock.inventory, id: stock_inventory_same_location}:
+    company_id: base.main_company
+    date: !eval time.strftime('%Y-%m-%d %H:%M:%S')
+    date_done: !eval time.strftime('%Y-%m-%d %H:%M:%S')
+    name: Physical inventory
+    state: draft
+-
+  I create a stock.fill.inventory wizard .
+-
+  !record {model: stock.fill.inventory, id: stock_fill_inventory_1}:
+    location_id: stock.stock_location_14
+-
+  I fill the inventory for location stock_location_14.
+-
+  !python {model: stock.fill.inventory}: |
+    from osv import osv
+    self.fill_inventory(cr, uid, [ref("stock_fill_inventory_1")], {"lang": 'en_US',
+      "full": "1", "tz": False, "active_model": "stock.inventory", "active_ids":
+      [ref("stock_inventory_same_location")], "active_id": ref("stock_inventory_same_location"), })
+-
+  I confirm and validate inventory - the quantity available must not change
+-
+  !python {model: stock.inventory}: |
+    prod_obj = self.pool.get("product.product")
+    old_qty = prod_obj.read(cr, uid, [ref('product.product_product_9')], ['qty_available'])[0]['qty_available']
+    self.action_confirm(cr,uid,[ref('stock_inventory_same_location')])
+    self.action_done(cr,uid,[ref('stock_inventory_same_location')])
+    new_qty = prod_obj.read(cr, uid, [ref('product.product_product_9')], ['qty_available'])[0]['qty_available']
+    assert old_qty == new_qty, "The quantity available should not change (%s -> %s)." % (old_qty, new_qty)