Merge lp:~nskaggs/ubuntu-filemanager-app/finish-py3-ap-conversion into lp:ubuntu-filemanager-app
Proposed by
Nicholas Skaggs
Status: | Rejected |
---|---|
Rejected by: | Nicholas Skaggs |
Proposed branch: | lp:~nskaggs/ubuntu-filemanager-app/finish-py3-ap-conversion |
Merge into: | lp:ubuntu-filemanager-app |
Diff against target: |
122 lines (+9/-16) 5 files modified
debian/control (+4/-3) tests/autopilot/CMakeLists.txt (+1/-1) tests/autopilot/filemanager/emulators.py (+3/-9) tests/autopilot/filemanager/tests/__init__.py (+1/-1) tests/autopilot/filemanager/tests/test_filemanager.py (+0/-2) |
To merge this branch: | bzr merge lp:~nskaggs/ubuntu-filemanager-app/finish-py3-ap-conversion |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
David Planella | Needs Fixing | ||
Review via email: mp+218478@code.launchpad.net |
Commit message
py3 ap conversion
Description of the change
DO NOT MERGE, jenkins test
To post a comment you must log in.
Unmerged revisions
- 175. By Nicholas Skaggs
-
removed hardcoding, use python3 as depends
- 174. By Nicholas Skaggs
-
hardcode ap dir, resume using py3 in cmakelists
- 173. By Nicholas Skaggs
-
add back py3 changes, revert cmakelists
- 172. By Nicholas Skaggs
-
revert everything, trunk build
- 171. By Nicholas Skaggs
-
add depends
Same error, hmmm.
CMake Error at tests/autopilot /CMakeLists. txt:5 (install):
install DIRECTORY given no DESTINATION!