Merge lp:~nskaggs/music-app/prevent-incorrect-no-music-screen into lp:music-app/trusty

[Nicholas Skaggs]

Wait until model is populated before deciding there is no music. There was a new prototype to the Songs model added that provides a "filled" signal that we should listen to in order to determine the model is full.

Wait until model is populated before deciding there is no music. There was a new prototype to the Songs model added that provides a "filled" signal that we should listen to in order to determine the model is full.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:543
http://91.189.93.70:8080/job/music-app-ci/966/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1219
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1219/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/190

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/966/rebuild

review: Needs Fixing (continuous-integration)

[Andrew Hayzen (ahayzen)]

Looks good so far, just wonder if onFilled would be better if it works? See inline diff comments.

review: Needs Information

[Victor Thompson (vthompson)]

That should work and is more readable. I'll fix this tonight.

review: Needs Fixing

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:544
http://91.189.93.70:8080/job/music-app-ci/972/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1283
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1283/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/196

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/972/rebuild

review: Needs Fixing (continuous-integration)

[Victor Thompson (vthompson)]

review: Abstain

[Andrew Hayzen (ahayzen)]

LGTM

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

[Nicholas Skaggs (nskaggs)]

I'm unsure why we are seeing,

bzrlib.errors.UnknownErrorFromSmartServer: Server sent an unexpected error: ('error', 'GhostRevisionsHaveNoRevno', 'Could not determine revno for {<email address hidden>} because its ancestry shows a ghost at {<email address hidden>}')

so I recreated the branch and MP with hopefully a clean history this time.

[Nicholas Skaggs (nskaggs)]

Top approving based on previous top approval.

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:559
http://91.189.93.70:8080/job/music-app-ci/985/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1396
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1396/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/209

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/985/rebuild

review: Approve (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'music-app.qml'
--- music-app.qml	2014-08-07 01:56:33 +0000
+++ music-app.qml	2014-08-07 14:25:56 +0000
@@ -498,8 +498,10 @@
     }
 
     SongsModel {
+        property bool populated: false
         id: allSongsModel
         store: musicStore
+        onFilled: populated = true
     }
 
     SongsModel {
@@ -909,7 +911,7 @@
             title: i18n.tr("Music")
             visible: false
 
-            property bool noMusic: allSongsModel.rowCount === 0 && loadedUI
+            property bool noMusic: allSongsModel.rowCount === 0 && allSongsModel.populated && loadedUI
 
             onNoMusicChanged: {
                 if (noMusic)