Merge lp:~nikwen/ubuntu-terminal-app/layouts-click-full-width into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Proposed by Niklas Wenzel
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 108
Merged at revision: 109
Proposed branch: lp:~nikwen/ubuntu-terminal-app/layouts-click-full-width
Merge into: lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 22 lines (+5/-1)
1 file modified
src/app/qml/LayoutsPage.qml (+5/-1)
To merge this branch: bzr merge lp:~nikwen/ubuntu-terminal-app/layouts-click-full-width
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+266667@code.launchpad.net

Commit message

Allow triggering the layout enabled switch by clicking anywhere on the ListItem

Description of the change

Allow triggering the layout enabled switch by clicking anywhere on the ListItem

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

This is great, thanks Niklas!

review: Approve
Revision history for this message
Niklas Wenzel (nikwen) wrote :

Thanks for merging. :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/app/qml/LayoutsPage.qml'
--- src/app/qml/LayoutsPage.qml 2015-03-26 22:32:38 +0000
+++ src/app/qml/LayoutsPage.qml 2015-08-02 13:14:30 +0000
@@ -35,13 +35,17 @@
35 anchors.fill: parent35 anchors.fill: parent
36 model: settings.profilesList36 model: settings.profilesList
37 delegate: ListItem.Standard {37 delegate: ListItem.Standard {
38 text: name
39
38 control: Switch {40 control: Switch {
41 id: layoutSwitch
39 checked: profileVisible42 checked: profileVisible
40 onCheckedChanged: {43 onCheckedChanged: {
41 settings.profilesList.setProperty(index, "profileVisible", checked);44 settings.profilesList.setProperty(index, "profileVisible", checked);
42 }45 }
43 }46 }
44 text: name47
48 onTriggered: layoutSwitch.trigger()
45 }49 }
46 }50 }
47}51}

Subscribers

People subscribed via source and target branches