Merge lp:~nico-inattendu/luciole/bug_740324 into lp:luciole

Proposed by NicoInattendu
Status: Merged
Approved by: NicoInattendu
Approved revision: 130
Merged at revision: 130
Proposed branch: lp:~nico-inattendu/luciole/bug_740324
Merge into: lp:luciole
Diff against target: 394 lines (+115/-37)
5 files modified
luciole/gui/actions.py (+44/-7)
luciole/gui/constants.py (+3/-0)
luciole/po/POTFILES.in (+4/-5)
luciole/ui/luciole.glade (+59/-20)
luciole/version.py (+5/-5)
To merge this branch: bzr merge lp:~nico-inattendu/luciole/bug_740324
Reviewer Review Type Date Requested Status
NicoInattendu Pending
Review via email: mp+54824@code.launchpad.net

Commit message

fix for bug #740324. : About window added, actions report a bug, ask a question and help translate also added.

Description of the change

fix for bug #740324.
About window added, actions report a bug, ask a question and help translate also added.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'luciole/gui/actions.py'
--- luciole/gui/actions.py 2011-03-05 13:59:13 +0000
+++ luciole/gui/actions.py 2011-03-25 09:26:06 +0000
@@ -3,7 +3,7 @@
3# -*- Mode: Python -*-3# -*- Mode: Python -*-
4# vim:si:ai:et:sw=4:sts=4:ts=44# vim:si:ai:et:sw=4:sts=4:ts=4
5#5#
6# Copyright Nicolas Bertrand (nico@inattendu.org), 20106# Copyright Nicolas Bertrand (nico@inattendu.org), 2010-2011
7#7#
8# This file is part of Luciole.8# This file is part of Luciole.
9#9#
@@ -27,6 +27,7 @@
27"""27"""
28# standard library imports28# standard library imports
29from gettext import gettext as _29from gettext import gettext as _
30import webbrowser
3031
31# related third party imports32# related third party imports
32import gobject33import gobject
@@ -38,7 +39,7 @@
38import luciole.gui.constants as GUI_CONST39import luciole.gui.constants as GUI_CONST
39import luciole.constants as LCONST40import luciole.constants as LCONST
40from luciole.gui.windows.export_video_window import ExportVideoWindow41from luciole.gui.windows.export_video_window import ExportVideoWindow
4142from luciole.info import REVNO, VERSION
42_tv_change_signal = 'treeview-change'43_tv_change_signal = 'treeview-change'
43_tv_selected_signal = 'treeview-selected'44_tv_selected_signal = 'treeview-selected'
4445
@@ -183,6 +184,12 @@
183 self._preferences_cb),184 self._preferences_cb),
184 (self.builder_actions[GUI_CONST.ACTION_ABOUT],185 (self.builder_actions[GUI_CONST.ACTION_ABOUT],
185 self._about_cb),186 self._about_cb),
187 (self.builder_actions[GUI_CONST.ACTION_BUG],
188 self._bug_cb),
189 (self.builder_actions[GUI_CONST.ACTION_ASK],
190 self._ask_cb),
191 (self.builder_actions[GUI_CONST.ACTION_I18N],
192 self._i18n_cb),
186 ]193 ]
187194
188 #195 #
@@ -457,11 +464,41 @@
457 pass464 pass
458465
459 def _about_cb(self, action ) :466 def _about_cb(self, action ) :
460 # TODO : implement About dialog467 _ver = "%s (%s)"%(VERSION, REVNO)
461 pass468 self.debug('show about dialog: version %s', _ver)
462469 self.gui.windows.about(_ver)
463 470
464 471 def _bug_cb(self, action ) :
472 """ report bug action """
473 self.debug('Report bug action')
474 try:
475 webbrowser.open("https://bugs.launchpad.net/luciole/+filebug")
476 except:
477 _msg = _("Unable to open the Launchpad web page.")
478 self.warning(_msg)
479 self.gui.windows.error_message(_msg)
480
481 def _ask_cb(self, action ) :
482 """ ask a question action """
483 self.debug('Ask a question action')
484 try:
485 webbrowser.open("https://answers.launchpad.net/luciole/+addquestion")
486 except:
487 _msg = _("Unable to open the Launchpad web page.")
488 self.warning(_msg)
489 self.gui.windows.error_message(_msg)
490
491 def _i18n_cb(self, action ) :
492 """ Help trranslate action """
493 self.debug('Help translate action')
494 try:
495 webbrowser.open("https://translations.launchpad.net/luciole")
496 except:
497 _msg = _("Unable to open the Launchpad web page.")
498 self.warning(_msg)
499 self.gui.windows.error_message(_msg)
500
501
465 #502 #
466 # project common callbacks503 # project common callbacks
467 #504 #
468505
=== modified file 'luciole/gui/constants.py'
--- luciole/gui/constants.py 2011-02-27 18:32:53 +0000
+++ luciole/gui/constants.py 2011-03-25 09:26:06 +0000
@@ -64,6 +64,9 @@
64ACTION_PREFERENCES = "ActionPreferences"64ACTION_PREFERENCES = "ActionPreferences"
65ACTION_OPEN = "ActionOpen"65ACTION_OPEN = "ActionOpen"
66ACTION_NEW = "ActionNew"66ACTION_NEW = "ActionNew"
67ACTION_BUG = "ActionReportBug"
68ACTION_ASK = "ActionAsk"
69ACTION_I18N = "ActionTranslate"
6770
68ACTION_CLOSE = "ActionClose"71ACTION_CLOSE = "ActionClose"
69ACTION_SAVE = "ActionSave"72ACTION_SAVE = "ActionSave"
7073
=== modified file 'luciole/po/POTFILES.in'
--- luciole/po/POTFILES.in 2010-09-06 12:10:40 +0000
+++ luciole/po/POTFILES.in 2011-03-25 09:26:06 +0000
@@ -1,15 +1,12 @@
1[encoding: UTF-8]1[encoding: UTF-8]
2../luciole/ui/luciole.glade
3../luciole/ui/export_file.glade
4../luciole/base/lcl_et.py2../luciole/base/lcl_et.py
5../luciole/conf.py3../luciole/conf.py
6../luciole/constants.py4../luciole/constants.py
7../luciole/ctrl/ctrl.py
8../luciole/ctrl/import_image.py5../luciole/ctrl/import_image.py
9../luciole/ctrl/load_rush.py6../luciole/ctrl/load_rush.py
10../luciole/ctrl/project_ctrl.py7../luciole/ctrl/ctrl_project.py
11../luciole/ctrl/viewer_ctrl.py
12../luciole/gui/control_widget.py8../luciole/gui/control_widget.py
9../luciole/gui/windows/actions.py
13../luciole/gui/windows/assistant_new_project.py10../luciole/gui/windows/assistant_new_project.py
14../luciole/gui/windows/dialog_project_properties.py11../luciole/gui/windows/dialog_project_properties.py
15../luciole/gui/windows/dialog.py12../luciole/gui/windows/dialog.py
@@ -22,3 +19,5 @@
22../luciole/project/export/export_pitivi.py19../luciole/project/export/export_pitivi.py
23../luciole/project/export/export_tool_base.py20../luciole/project/export/export_tool_base.py
24../luciole/project/export/export_video.py21../luciole/project/export/export_video.py
22../luciole/ui/export_file.glade
23../luciole/ui/luciole.glade
2524
=== modified file 'luciole/ui/luciole.glade'
--- luciole/ui/luciole.glade 2011-02-28 12:58:02 +0000
+++ luciole/ui/luciole.glade 2011-03-25 09:26:06 +0000
@@ -1,4 +1,4 @@
1<?xml version="1.0"?>1<?xml version="1.0" encoding="UTF-8"?>
2<interface>2<interface>
3 <requires lib="gtk+" version="2.16"/>3 <requires lib="gtk+" version="2.16"/>
4 <!-- interface-naming-policy toplevel-contextual -->4 <!-- interface-naming-policy toplevel-contextual -->
@@ -71,8 +71,8 @@
71 <child>71 <child>
72 <object class="GtkImageMenuItem" id="file_new">72 <object class="GtkImageMenuItem" id="file_new">
73 <property name="visible">True</property>73 <property name="visible">True</property>
74 <property name="use_action_appearance">True</property>
75 <property name="related_action">ActionNew</property>74 <property name="related_action">ActionNew</property>
75 <property name="use_action_appearance">True</property>
76 <property name="use_underline">True</property>76 <property name="use_underline">True</property>
77 <property name="use_stock">True</property>77 <property name="use_stock">True</property>
78 <signal name="activate" handler="on_file_new_activate"/>78 <signal name="activate" handler="on_file_new_activate"/>
@@ -81,8 +81,8 @@
81 <child>81 <child>
82 <object class="GtkImageMenuItem" id="file_open">82 <object class="GtkImageMenuItem" id="file_open">
83 <property name="visible">True</property>83 <property name="visible">True</property>
84 <property name="use_action_appearance">True</property>
85 <property name="related_action">ActionOpen</property>84 <property name="related_action">ActionOpen</property>
85 <property name="use_action_appearance">True</property>
86 <property name="use_underline">True</property>86 <property name="use_underline">True</property>
87 <property name="use_stock">True</property>87 <property name="use_stock">True</property>
88 </object>88 </object>
@@ -137,8 +137,8 @@
137 <child>137 <child>
138 <object class="GtkImageMenuItem" id="imagemenuitem3">138 <object class="GtkImageMenuItem" id="imagemenuitem3">
139 <property name="visible">True</property>139 <property name="visible">True</property>
140 <property name="use_action_appearance">True</property>
141 <property name="related_action">ActionSave</property>140 <property name="related_action">ActionSave</property>
141 <property name="use_action_appearance">True</property>
142 <property name="use_underline">True</property>142 <property name="use_underline">True</property>
143 <property name="use_stock">True</property>143 <property name="use_stock">True</property>
144 <signal name="activate" handler="on_file_save_activate"/>144 <signal name="activate" handler="on_file_save_activate"/>
@@ -147,8 +147,8 @@
147 <child>147 <child>
148 <object class="GtkImageMenuItem" id="imagemenuitem4">148 <object class="GtkImageMenuItem" id="imagemenuitem4">
149 <property name="visible">True</property>149 <property name="visible">True</property>
150 <property name="use_action_appearance">True</property>
151 <property name="related_action">ActionSaveAs</property>150 <property name="related_action">ActionSaveAs</property>
151 <property name="use_action_appearance">True</property>
152 <property name="use_underline">True</property>152 <property name="use_underline">True</property>
153 <property name="use_stock">True</property>153 <property name="use_stock">True</property>
154 <signal name="activate" handler="on_file_save_as_activate"/>154 <signal name="activate" handler="on_file_save_as_activate"/>
@@ -162,8 +162,8 @@
162 <child>162 <child>
163 <object class="GtkImageMenuItem" id="file_import">163 <object class="GtkImageMenuItem" id="file_import">
164 <property name="visible">True</property>164 <property name="visible">True</property>
165 <property name="use_action_appearance">True</property>
166 <property name="related_action">ActionImportImage</property>165 <property name="related_action">ActionImportImage</property>
166 <property name="use_action_appearance">True</property>
167 <property name="use_underline">True</property>167 <property name="use_underline">True</property>
168 <property name="use_stock">True</property>168 <property name="use_stock">True</property>
169 <signal name="activate" handler="on_file_import_activate"/>169 <signal name="activate" handler="on_file_import_activate"/>
@@ -172,8 +172,8 @@
172 <child>172 <child>
173 <object class="GtkImageMenuItem" id="file_export">173 <object class="GtkImageMenuItem" id="file_export">
174 <property name="visible">True</property>174 <property name="visible">True</property>
175 <property name="use_action_appearance">True</property>
176 <property name="related_action">ActionExportVideo</property>175 <property name="related_action">ActionExportVideo</property>
176 <property name="use_action_appearance">True</property>
177 <property name="use_underline">True</property>177 <property name="use_underline">True</property>
178 <property name="use_stock">True</property>178 <property name="use_stock">True</property>
179 <signal name="activate" handler="on_file_export_activate"/>179 <signal name="activate" handler="on_file_export_activate"/>
@@ -182,8 +182,8 @@
182 <child>182 <child>
183 <object class="GtkImageMenuItem" id="file_export_tool">183 <object class="GtkImageMenuItem" id="file_export_tool">
184 <property name="visible">True</property>184 <property name="visible">True</property>
185 <property name="use_action_appearance">True</property>
186 <property name="related_action">ActionExportTool</property>185 <property name="related_action">ActionExportTool</property>
186 <property name="use_action_appearance">True</property>
187 <property name="use_underline">True</property>187 <property name="use_underline">True</property>
188 <property name="use_stock">True</property>188 <property name="use_stock">True</property>
189 <signal name="activate" handler="on_file_export_tool_activate"/>189 <signal name="activate" handler="on_file_export_tool_activate"/>
@@ -197,8 +197,8 @@
197 <child>197 <child>
198 <object class="GtkImageMenuItem" id="file_close">198 <object class="GtkImageMenuItem" id="file_close">
199 <property name="visible">True</property>199 <property name="visible">True</property>
200 <property name="use_action_appearance">True</property>
201 <property name="related_action">ActionClose</property>200 <property name="related_action">ActionClose</property>
201 <property name="use_action_appearance">True</property>
202 <property name="use_underline">True</property>202 <property name="use_underline">True</property>
203 <property name="use_stock">True</property>203 <property name="use_stock">True</property>
204 <signal name="activate" handler="on_file_close_activate"/>204 <signal name="activate" handler="on_file_close_activate"/>
@@ -207,8 +207,8 @@
207 <child>207 <child>
208 <object class="GtkImageMenuItem" id="imagemenuitem5">208 <object class="GtkImageMenuItem" id="imagemenuitem5">
209 <property name="visible">True</property>209 <property name="visible">True</property>
210 <property name="use_action_appearance">True</property>
211 <property name="related_action">ActionQuit</property>210 <property name="related_action">ActionQuit</property>
211 <property name="use_action_appearance">True</property>
212 <property name="use_underline">True</property>212 <property name="use_underline">True</property>
213 <property name="use_stock">True</property>213 <property name="use_stock">True</property>
214 <signal name="activate" handler="on_file_quit_activate"/>214 <signal name="activate" handler="on_file_quit_activate"/>
@@ -229,8 +229,8 @@
229 <child>229 <child>
230 <object class="GtkImageMenuItem" id="view_project">230 <object class="GtkImageMenuItem" id="view_project">
231 <property name="visible">True</property>231 <property name="visible">True</property>
232 <property name="use_action_appearance">True</property>
233 <property name="related_action">ActionProjectProperties</property>232 <property name="related_action">ActionProjectProperties</property>
233 <property name="use_action_appearance">True</property>
234 <property name="use_underline">True</property>234 <property name="use_underline">True</property>
235 <property name="use_stock">True</property>235 <property name="use_stock">True</property>
236 <signal name="activate" handler="on_view_project_activate"/>236 <signal name="activate" handler="on_view_project_activate"/>
@@ -239,8 +239,8 @@
239 <child>239 <child>
240 <object class="GtkImageMenuItem" id="Preferences_menu">240 <object class="GtkImageMenuItem" id="Preferences_menu">
241 <property name="visible">True</property>241 <property name="visible">True</property>
242 <property name="use_action_appearance">True</property>
243 <property name="related_action">ActionPreferences</property>242 <property name="related_action">ActionPreferences</property>
243 <property name="use_action_appearance">True</property>
244 <property name="use_underline">True</property>244 <property name="use_underline">True</property>
245 <property name="use_stock">True</property>245 <property name="use_stock">True</property>
246 <signal name="activate" handler="on_preferences_activate"/>246 <signal name="activate" handler="on_preferences_activate"/>
@@ -261,8 +261,8 @@
261 <child>261 <child>
262 <object class="GtkRadioMenuItem" id="start_stop_acqusition_item">262 <object class="GtkRadioMenuItem" id="start_stop_acqusition_item">
263 <property name="visible">True</property>263 <property name="visible">True</property>
264 <property name="use_action_appearance">True</property>
265 <property name="related_action">start_stop_acquisition</property>264 <property name="related_action">start_stop_acquisition</property>
265 <property name="use_action_appearance">True</property>
266 </object>266 </object>
267 </child>267 </child>
268 </object>268 </object>
@@ -278,10 +278,42 @@
278 <object class="GtkMenu" id="menu3">278 <object class="GtkMenu" id="menu3">
279 <property name="visible">True</property>279 <property name="visible">True</property>
280 <child>280 <child>
281 <object class="GtkImageMenuItem" id="mnuReportBug">
282 <property name="visible">True</property>
283 <property name="related_action">ActionReportBug</property>
284 <property name="use_action_appearance">True</property>
285 <property name="use_underline">True</property>
286 <property name="use_stock">True</property>
287 </object>
288 </child>
289 <child>
290 <object class="GtkImageMenuItem" id="MnuAskQquestion">
291 <property name="visible">True</property>
292 <property name="related_action">ActionAsk</property>
293 <property name="use_action_appearance">True</property>
294 <property name="use_underline">True</property>
295 <property name="use_stock">True</property>
296 </object>
297 </child>
298 <child>
299 <object class="GtkImageMenuItem" id="mnuTranslate">
300 <property name="visible">True</property>
301 <property name="related_action">ActionTranslate</property>
302 <property name="use_action_appearance">True</property>
303 <property name="use_underline">True</property>
304 <property name="use_stock">True</property>
305 </object>
306 </child>
307 <child>
308 <object class="GtkSeparatorMenuItem" id="menuitem2">
309 <property name="visible">True</property>
310 </object>
311 </child>
312 <child>
281 <object class="GtkImageMenuItem" id="help_about">313 <object class="GtkImageMenuItem" id="help_about">
282 <property name="visible">True</property>314 <property name="visible">True</property>
283 <property name="use_action_appearance">True</property>
284 <property name="related_action">ActionAbout</property>315 <property name="related_action">ActionAbout</property>
316 <property name="use_action_appearance">True</property>
285 <property name="use_underline">True</property>317 <property name="use_underline">True</property>
286 <property name="use_stock">True</property>318 <property name="use_stock">True</property>
287 <signal name="activate" handler="on_help_about_activate"/>319 <signal name="activate" handler="on_help_about_activate"/>
@@ -665,7 +697,6 @@
665 <property name="title" translatable="yes">Select a Luciole project</property>697 <property name="title" translatable="yes">Select a Luciole project</property>
666 <property name="window_position">center-on-parent</property>698 <property name="window_position">center-on-parent</property>
667 <property name="type_hint">menu</property>699 <property name="type_hint">menu</property>
668 <property name="has_separator">False</property>
669 <child internal-child="vbox">700 <child internal-child="vbox">
670 <object class="GtkVBox" id="dialog-vbox1">701 <object class="GtkVBox" id="dialog-vbox1">
671 <property name="visible">True</property>702 <property name="visible">True</property>
@@ -700,7 +731,6 @@
700 <property name="resizable">False</property>731 <property name="resizable">False</property>
701 <property name="window_position">center-on-parent</property>732 <property name="window_position">center-on-parent</property>
702 <property name="type_hint">dialog</property>733 <property name="type_hint">dialog</property>
703 <property name="has_separator">False</property>
704 <property name="program_name">Luciole</property>734 <property name="program_name">Luciole</property>
705 <property name="version">0.8</property>735 <property name="version">0.8</property>
706 <property name="copyright" translatable="yes">Copyright 2009-2010 Nicolas Bertrand (nico@inattendu.org)</property>736 <property name="copyright" translatable="yes">Copyright 2009-2010 Nicolas Bertrand (nico@inattendu.org)</property>
@@ -763,7 +793,6 @@
763 <property name="title" translatable="yes">Video Export</property>793 <property name="title" translatable="yes">Video Export</property>
764 <property name="window_position">center-on-parent</property>794 <property name="window_position">center-on-parent</property>
765 <property name="type_hint">dialog</property>795 <property name="type_hint">dialog</property>
766 <property name="has_separator">False</property>
767 <child internal-child="vbox">796 <child internal-child="vbox">
768 <object class="GtkVBox" id="dialog-vbox11">797 <object class="GtkVBox" id="dialog-vbox11">
769 <property name="visible">True</property>798 <property name="visible">True</property>
@@ -1044,9 +1073,9 @@
1044 <object class="GtkFileChooserButton" id="filechooserbutton1">1073 <object class="GtkFileChooserButton" id="filechooserbutton1">
1045 <property name="visible">True</property>1074 <property name="visible">True</property>
1046 <property name="events">GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK</property>1075 <property name="events">GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK</property>
1076 <property name="action">select-folder</property>
1047 <property name="do_overwrite_confirmation">True</property>1077 <property name="do_overwrite_confirmation">True</property>
1048 <property name="use_preview_label">False</property>1078 <property name="use_preview_label">False</property>
1049 <property name="action">select-folder</property>
1050 <property name="title" translatable="yes">Select a folder</property>1079 <property name="title" translatable="yes">Select a folder</property>
1051 </object>1080 </object>
1052 <packing>1081 <packing>
@@ -1268,7 +1297,6 @@
1268 <property name="border_width">5</property>1297 <property name="border_width">5</property>
1269 <property name="window_position">center-on-parent</property>1298 <property name="window_position">center-on-parent</property>
1270 <property name="type_hint">dialog</property>1299 <property name="type_hint">dialog</property>
1271 <property name="has_separator">False</property>
1272 <child internal-child="vbox">1300 <child internal-child="vbox">
1273 <object class="GtkVBox" id="dialog-vbox4">1301 <object class="GtkVBox" id="dialog-vbox4">
1274 <property name="visible">True</property>1302 <property name="visible">True</property>
@@ -1304,7 +1332,6 @@
1304 <property name="title" translatable="yes">Preferences</property>1332 <property name="title" translatable="yes">Preferences</property>
1305 <property name="window_position">center-on-parent</property>1333 <property name="window_position">center-on-parent</property>
1306 <property name="type_hint">dialog</property>1334 <property name="type_hint">dialog</property>
1307 <property name="has_separator">False</property>
1308 <child internal-child="vbox">1335 <child internal-child="vbox">
1309 <object class="GtkVBox" id="dialog-vbox3">1336 <object class="GtkVBox" id="dialog-vbox3">
1310 <property name="height_request">269</property>1337 <property name="height_request">269</property>
@@ -1550,4 +1577,16 @@
1550 <object class="GtkAction" id="ActionProjectProperties">1577 <object class="GtkAction" id="ActionProjectProperties">
1551 <property name="stock_id">gtk-properties</property>1578 <property name="stock_id">gtk-properties</property>
1552 </object>1579 </object>
1580 <object class="GtkAction" id="ActionReportBug">
1581 <property name="label">_Report a Bug...</property>
1582 <property name="stock_id">gtk-dialog-warning</property>
1583 </object>
1584 <object class="GtkAction" id="ActionAsk">
1585 <property name="label">_Ask a Question...</property>
1586 <property name="stock_id">gtk-dialog-question</property>
1587 </object>
1588 <object class="GtkAction" id="ActionTranslate">
1589 <property name="label">_Translate this Application...</property>
1590 <property name="stock_id">gtk-index</property>
1591 </object>
1553</interface>1592</interface>
15541593
=== modified file 'luciole/version.py'
--- luciole/version.py 2010-09-06 11:02:42 +0000
+++ luciole/version.py 2011-03-25 09:26:06 +0000
@@ -4,12 +4,12 @@
4So don't edit it. :)4So don't edit it. :)
5"""5"""
66
7version_info = {'branch_nick': u'luciole',7version_info = {'branch_nick': u'bug_740324',
8 'build_date': '2010-09-06 15:01:02 +0400',8 'build_date': '2011-03-24 19:11:26 +0100',
9 'clean': None,9 'clean': None,
10 'date': '2010-09-06 13:00:55 +0400',10 'date': '2011-03-09 15:52:21 +0400',
11 'revision_id': 'nico@inattendu.org-20100906090055-iafu3ghe623sroam',11 'revision_id': 'nico@inattendu.org-20110309115221-l1nzqwerhwwcz9jf',
12 'revno': 117}12 'revno': 129}
1313
14revisions = {}14revisions = {}
1515

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: