Merge lp:~niclasl/scratch/fix-padding into lp:scratch/2.x

[Niclas Lockner]

Add padding around the new tab button

Add padding around the new tab button

[lp:~niclasl/scratch/fix-padding]

1229. By Niclas Lockner on 2013-12-11

Add padding around the new tab button

[Niclas Lockner (niclasl)]

Now it's ready for review.

[Mario Guerriero (mefrio-g)]

review: Approve

=== modified file 'src/Widgets/DynamicNotebook.vala'
--- src/Widgets/DynamicNotebook.vala	2013-10-30 19:44:28 +0000
+++ src/Widgets/DynamicNotebook.vala	2013-12-11 19:08:51 +0000
@@ -435,6 +435,7 @@
         private Gtk.Button add_button;
         private Gtk.Button restore_button; // should be a Gtk.MenuButton when we have Gtk+ 3.6
 
+        private static const int ADD_BUTTON_PADDING = 5; // Padding around the new tab button
         private static const string CLOSE_BUTTON_STYLE = """
         * {
             -GtkButton-default-border : 0;
@@ -494,14 +495,15 @@
                 this.tab_restored (tab);
             });
 
+            Gtk.Box add_button_box = new Gtk.Box (Gtk.Orientation.HORIZONTAL, 0);
             add_button = new Gtk.Button ();
             add_button.add (new Gtk.Image.from_icon_name ("list-add-symbolic", Gtk.IconSize.MENU));
-            add_button.margin_left = 6;
             add_button.relief = Gtk.ReliefStyle.NONE;
             add_button.tooltip_text = _("New Tab");
-            this.notebook.set_action_widget (add_button, Gtk.PackType.START);
-            add_button.show_all ();
             add_button.get_style_context ().add_provider (button_fix, Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION);
+            add_button_box.pack_start (add_button, false, false, ADD_BUTTON_PADDING);
+            add_button_box.show_all ();
+            this.notebook.set_action_widget (add_button_box, Gtk.PackType.START);
 
             restore_button = new Gtk.Button ();
             restore_button.add (new Gtk.Image.from_icon_name ("user-trash-symbolic", Gtk.IconSize.MENU));