Merge lp:~newell-jensen/maas/fix-1592885 into lp:~maas-committers/maas/trunk

[Newell Jensen]

The region service is using logger.basicConfig for setting the log messags. This branch updates the rack service to use the same setup as the region service so that we can get consistent messaging between the two.

[Newell Jensen (newell-jensen)]

Since maas.log is generated from syslog, we are leaving that one as it currently is.

[Gavin Panella (allenap)]

Tip top!

review: Approve

=== modified file 'src/provisioningserver/plugin.py'
--- src/provisioningserver/plugin.py	2016-06-03 17:34:13 +0000
+++ src/provisioningserver/plugin.py	2016-06-21 21:29:22 +0000
@@ -170,12 +170,18 @@
         import crochet
         crochet.no_setup()
 
+    def _configureLogging(self):
+        # Get something going with the logs.
+        from provisioningserver import logger
+        logger.basicConfig()
+
     def makeService(self, options):
         """Construct the MAAS Cluster service."""
         register_sigusr2_thread_dump_handler()
         add_term_error_code_to_tftp()
 
         self._configureCrochet()
+        self._configureLogging()
 
         with ClusterConfiguration.open() as config:
             tftp_root = config.tftp_root
 
=== modified file 'src/provisioningserver/tests/test_plugin.py'
--- src/provisioningserver/tests/test_plugin.py	2016-06-03 17:34:13 +0000
+++ src/provisioningserver/tests/test_plugin.py	2016-06-21 21:29:22 +0000
@@ -12,7 +12,10 @@
     MAASTwistedRunTest,
 )
 import provisioningserver
-from provisioningserver import plugin as plugin_module
+from provisioningserver import (
+    logger,
+    plugin as plugin_module,
+)
 from provisioningserver.config import ClusterConfiguration
 from provisioningserver.plugin import (
     Options,
@@ -78,6 +81,7 @@
         self.useFixture(ClusterConfigurationFixture())
         self.patch(provisioningserver, "services", MultiService())
         self.patch_autospec(crochet, "no_setup")
+        self.patch_autospec(logger, "basicConfig")
         self.tempdir = self.make_dir()
 
     def test_init(self):
@@ -104,6 +108,7 @@
             "Not all services are named.")
         self.assertEqual(service, provisioningserver.services)
         self.assertThat(crochet.no_setup, MockCalledOnceWith())
+        self.assertThat(logger.basicConfig, MockCalledOnceWith())
 
     def test_makeService_patches_tftp_service(self):
         mock_tftp_patch = (