Merge lp:~neokore/ubuntu-weather-app/improveSheetsText into lp:ubuntu-weather-app/obsolete.trunk

Proposed by Raúl Yeguas
Status: Merged
Approved by: Martin Borho
Approved revision: 76
Merged at revision: 76
Proposed branch: lp:~neokore/ubuntu-weather-app/improveSheetsText
Merge into: lp:ubuntu-weather-app/obsolete.trunk
Diff against target: 83 lines (+17/-5)
2 files modified
components/LocationManagerSheet.qml (+7/-3)
components/SettingsSheet.qml (+10/-2)
To merge this branch: bzr merge lp:~neokore/ubuntu-weather-app/improveSheetsText
Reviewer Review Type Date Requested Status
Martin Borho Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+176521@code.launchpad.net

Commit message

Changed text color for settigns and location sheets to improve its readability.

Description of the change

Changed text color for settings and location sheets to improve its readability.
By now it's a bit tricky unless the SDK let us change this values or I learn to use themes correctly.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Martin Borho (martin-borho) wrote :

Haven't found a way to do so, very cool!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'components/LocationManagerSheet.qml'
--- components/LocationManagerSheet.qml 2013-07-19 11:39:31 +0000
+++ components/LocationManagerSheet.qml 2013-07-23 21:24:31 +0000
@@ -34,8 +34,9 @@
34 property int initial_sum: 034 property int initial_sum: 0
3535
36 Component.onCompleted: {36 Component.onCompleted: {
37 locationsRemoved.clear()37 locationsRemoved.clear();
38 loadData()38 loadData();
39 Theme.palette.selected.backgroundText = "#656565"
39 }40 }
4041
41 function loadData() {42 function loadData() {
@@ -136,7 +137,8 @@
136 width: parent.width137 width: parent.width
137 clip:true138 clip:true
138 color:"transparent"139 color:"transparent"
139 height: units.gu(40)140 height: units.gu(45)
141
140 ListView {142 ListView {
141 objectName: "LocationList"143 objectName: "LocationList"
142 anchors.fill: parent144 anchors.fill: parent
@@ -210,6 +212,7 @@
210 currentLocationItem.visible = false212 currentLocationItem.visible = false
211 locationLookupItem.visible = true213 locationLookupItem.visible = true
212 lookupItemAddButton.visible = true214 lookupItemAddButton.visible = true
215 Theme.palette.selected.backgroundText = "#f4f4e8"
213 }216 }
214217
215 onCancelClicked: {218 onCancelClicked: {
@@ -219,6 +222,7 @@
219 // opening the sheet222 // opening the sheet
220 mainView.refreshData()223 mainView.refreshData()
221 }224 }
225 Theme.palette.selected.backgroundText = "#f4f4e8"
222 }226 }
223227
224 AddLocationSheet {228 AddLocationSheet {
225229
=== modified file 'components/SettingsSheet.qml'
--- components/SettingsSheet.qml 2013-07-20 16:52:37 +0000
+++ components/SettingsSheet.qml 2013-07-23 21:24:31 +0000
@@ -22,12 +22,11 @@
22import Ubuntu.Components.ListItems 0.1 as ListItem22import Ubuntu.Components.ListItems 0.1 as ListItem
2323
24Component {24Component {
25
26 ComposerSheet {25 ComposerSheet {
27 id: sheet26 id: sheet
28 objectName: "SettingsSheet"27 objectName: "SettingsSheet"
29 title: i18n.tr("Settings")28 title: i18n.tr("Settings")
30 contentsHeight: parent.height 29 contentsHeight: parent.height
3130
32 container: ListItem.ValueSelector {31 container: ListItem.ValueSelector {
33 id: unitsSelector32 id: unitsSelector
@@ -37,6 +36,10 @@
37 selectedIndex: (settings["units"] === "imperial") ? 1 : 0;36 selectedIndex: (settings["units"] === "imperial") ? 1 : 0;
38 }37 }
3938
39 Component.onCompleted: {
40 Theme.palette.selected.backgroundText = "#656565"
41 }
42
40 onConfirmClicked: {43 onConfirmClicked: {
41 var refresh = false,44 var refresh = false,
42 selectedUnit = (unitsSelector.selectedIndex === 0) ? "metric" : "imperial";45 selectedUnit = (unitsSelector.selectedIndex === 0) ? "metric" : "imperial";
@@ -57,7 +60,12 @@
57 refreshData(true);60 refreshData(true);
58 });61 });
59 }62 }
63 Theme.palette.selected.backgroundText = "#f4f4e8"
60 PopupUtils.close(sheet)64 PopupUtils.close(sheet)
61 }65 }
66
67 onCancelClicked: {
68 Theme.palette.selected.backgroundText = "#f4f4e8"
69 }
62 }70 }
63}71}

Subscribers

People subscribed via source and target branches