Merge lp:~nataliabidart/ubuntuone-control-panel/out-of-space-notif into lp:ubuntuone-control-panel
Proposed by
Natalia Bidart
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Natalia Bidart | ||||||||
Approved revision: | 86 | ||||||||
Merged at revision: | 84 | ||||||||
Proposed branch: | lp:~nataliabidart/ubuntuone-control-panel/out-of-space-notif | ||||||||
Merge into: | lp:ubuntuone-control-panel | ||||||||
Diff against target: |
132 lines (+45/-17) 2 files modified
ubuntuone/controlpanel/gtk/gui.py (+15/-7) ubuntuone/controlpanel/gtk/tests/test_gui.py (+30/-10) |
||||||||
To merge this branch: | bzr merge lp:~nataliabidart/ubuntuone-control-panel/out-of-space-notif | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alejandro J. Cura (community) | Approve | ||
Martin Albisetti (community) | Approve | ||
Review via email: mp+51484@code.launchpad.net |
Description of the change
Screenshot of how this looks IRL is: http://
To post a comment you must log in.
14:46 < nessita> beuno: http:// ubuntuone. com/p/fMq/
14:47 < beuno> nessita, looks good to me
14:48 < beuno> do we only want to go red when they're >= 100?
14:48 < beuno> maybe 98/99 is enough?
14:48 < nessita> beuno: hum, good idea
14:48 < nessita> beuno: maybe >= 95
14:48 < nessita> beuno: that's a very good idea!
\o/