Merge lp:~nataliabidart/ubuntuone-control-panel/always-in-... into lp:ubuntuone-control-panel

Proposed by Natalia Bidart
Status: Merged
Approved by: Natalia Bidart
Approved revision: 307
Merged at revision: 302
Proposed branch: lp:~nataliabidart/ubuntuone-control-panel/always-in-...
Merge into: lp:ubuntuone-control-panel
Diff against target: 34 lines (+12/-1)
2 files modified
ubuntuone/controlpanel/gui/qt/folders.py (+1/-1)
ubuntuone/controlpanel/gui/qt/tests/test_folders.py (+11/-0)
To merge this branch: bzr merge lp:~nataliabidart/ubuntuone-control-panel/always-in-...
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Diego Sarmentero (community) Approve
Review via email: mp+99917@code.launchpad.net

Commit message

- Ensured that Folders' tree view has proper texts in the columns to have proper
  column widths (LP: #965175).

To post a comment you must log in.
303. By Natalia Bidart

Remove skip.

Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve
304. By Natalia Bidart

Merged trunk in.

305. By Natalia Bidart

Revert some changes.

306. By Natalia Bidart

- Add tests.

307. By Natalia Bidart

Better (and passing) test.

Revision history for this message
Roberto Alsina (ralsina) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ubuntuone/controlpanel/gui/qt/folders.py'
--- ubuntuone/controlpanel/gui/qt/folders.py 2012-03-20 13:05:20 +0000
+++ ubuntuone/controlpanel/gui/qt/folders.py 2012-03-29 15:29:19 +0000
@@ -123,7 +123,7 @@
123 self.ui.folders.headerItem().setText(FOLDER_NAME_COL,123 self.ui.folders.headerItem().setText(FOLDER_NAME_COL,
124 FOLDERS_COLUMN_NAME)124 FOLDERS_COLUMN_NAME)
125 self.ui.folders.headerItem().setText(SUBSCRIPTION_COL,125 self.ui.folders.headerItem().setText(SUBSCRIPTION_COL,
126 FOLDERS_COLUMN_SYNC_LOCALLY)126 ALWAYS_SUBSCRIBED)
127 self.ui.folders.headerItem().setText(EXPLORE_COL,127 self.ui.folders.headerItem().setText(EXPLORE_COL,
128 FOLDERS_COLUMN_EXPLORE)128 FOLDERS_COLUMN_EXPLORE)
129 headers = self.ui.folders.header()129 headers = self.ui.folders.header()
130130
=== modified file 'ubuntuone/controlpanel/gui/qt/tests/test_folders.py'
--- ubuntuone/controlpanel/gui/qt/tests/test_folders.py 2012-03-23 14:04:57 +0000
+++ ubuntuone/controlpanel/gui/qt/tests/test_folders.py 2012-03-29 15:29:19 +0000
@@ -409,6 +409,17 @@
409 item)409 item)
410 it += 1410 it += 1
411411
412 def test_tree_view_header(self):
413 """The tree view header is hidden but the text is correct."""
414 self.assertFalse(self.ui.ui.folders.header().isVisible())
415
416 name = self.ui.ui.folders.headerItem().text(gui.FOLDER_NAME_COL)
417 self.assertEqual(name, gui.FOLDERS_COLUMN_NAME)
418 name = self.ui.ui.folders.headerItem().text(gui.SUBSCRIPTION_COL)
419 self.assertEqual(name, gui.ALWAYS_SUBSCRIBED)
420 name = self.ui.ui.folders.headerItem().text(gui.EXPLORE_COL)
421 self.assertEqual(name, gui.FOLDERS_COLUMN_EXPLORE)
422
412 def test_share_publish_button(self):423 def test_share_publish_button(self):
413 """When clicking the share/publish button, the proper url is opened."""424 """When clicking the share/publish button, the proper url is opened."""
414 self.assertTrue(self.ui.ui.share_publish_button.isVisible())425 self.assertTrue(self.ui.ui.share_publish_button.isVisible())

Subscribers

People subscribed via source and target branches